Hi Yamamoto-San, Thank you for reviewing my patches.
On 2015年05月26日 16:56, YAMAMOTO Takashi wrote: >> This patch adds OXS class parser for Extensible Flow Entry >> Statistics in OpenFlow Spec 1.5. > > thank you for working on this. > >> diff --git a/ryu/ofproto/oxs_fields.py b/ryu/ofproto/oxs_fields.py >> new file mode 100644 >> index 0000000..ec2049b > > this module looks very similar to oxm_fields.py. > have you considered to share code? > i think the standard uses the same convention oxm and oxs > intentionally to allow implementers share the logic. I hadn't considered it. I'll try it. By the way, if merge the code of OXM and OXS, I think oxm_fields.py need to rename as ofpx_field.py or something, do you think it reasonable? OR... Do you prefer to add oxs_fields.py and with importing/reusing logics (eg. _from_user, etc) from oxm_fields.py? > >> + # 'count' is the number of OFPXST_OFB_* field value. >> + # eg. OFPXST_OFB_DURATION has two values in own field. >> + self.count = count > > i prefer to introduce type_desc.Duration or something like that instead. Thanks, I will try to re-implement with type_desc.IntDescrMlt or IntDescrDouble or something. > > YAMAMOTO Takashi > Thanks, Iwase ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
