Hi Yamamoto-San, On 2015年05月27日 16:27, YAMAMOTO Takashi wrote: >>>> diff --git a/ryu/ofproto/oxs_fields.py b/ryu/ofproto/oxs_fields.py >>>> new file mode 100644 >>>> index 0000000..ec2049b >>> >>> this module looks very similar to oxm_fields.py. >>> have you considered to share code? >>> i think the standard uses the same convention oxm and oxs >>> intentionally to allow implementers share the logic. >> >> I hadn't considered it. I'll try it. >> >> By the way, if merge the code of OXM and OXS, >> I think oxm_fields.py need to rename as ofpx_field.py or something, >> do you think it reasonable? >> >> OR... >> Do you prefer to add oxs_fields.py and with importing/reusing logics >> (eg. _from_user, etc) from oxm_fields.py? > > i don't have a strong preference either ways.
OK, Thank you. > > btw what does ofpx stand for? 'ofpx' is leading characters of 'OFPXMC_OPENFLOW_BASIC', 'OFPXSC_OPENFLOW_BASIC' and etc. Now, I'm implementing module which is shared by oxm_fields.py and oxs_fields.py as oxx_fields.py (temporarily). > > YAMAMOTO Takashi > Thanks, Iwase ------------------------------------------------------------------------------ _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
