At Tue, 11 Aug 2015 13:26:53 +0900 (JST), FUJITA Tomonori wrote: > > On Tue, 11 Aug 2015 09:32:21 +0900 > Yusuke Iwase <[email protected]> wrote: > > > The existing Makefile seems to suppose the BSD environment. > > This patch renames existing Makefile into "Makefile.BSD" and > > adds "Makefile.GNU" for GNU environment. > > > > Usage Example: > > > > - For BSD environment > > $ make -f Makefile.BSD > > > > - For GNU environment > > $ make -f Makefile.GNU > > > > Signed-off-by: IWASE Yusuke <[email protected]> > > --- > > ryu/tests/packet_data_generator2/Makefile | 35 ------------------------ > > ryu/tests/packet_data_generator2/Makefile.BSD | 35 ++++++++++++++++++++++++ > > ryu/tests/packet_data_generator2/Makefile.GNU | 39 > > +++++++++++++++++++++++++++ > > 3 files changed, 74 insertions(+), 35 deletions(-) > > delete mode 100644 ryu/tests/packet_data_generator2/Makefile > > create mode 100644 ryu/tests/packet_data_generator2/Makefile.BSD > > create mode 100644 ryu/tests/packet_data_generator2/Makefile.GNU > > Thanks, it's trivial so I applied this. However, I think that using a > single Makefile that can handle both OSes is the common way. > > We could delete generator2 and use generator3 instead. That's more > better.
My original intent was to kill generator2 in favor of generator3, but some features are missing in generator3. I don't think ovs-ofctl can generate packet_in, and some work is needed to capture bundle messages. If everybody is happy with generator3, generator2 can be shrinked and possibly deprecated in future, I think. -- IWAMOTO Toshihiro ------------------------------------------------------------------------------ _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
