At Wed,  7 Oct 2015 13:09:03 +0200,
Fadi Moukayed wrote:
> 
> Signed-off-by: Fadi Moukayed <[email protected]>
> ---
>  ryu/topology/switches.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ryu/topology/switches.py b/ryu/topology/switches.py
> index 5fe5d26..20d04fd 100644
> --- a/ryu/topology/switches.py
> +++ b/ryu/topology/switches.py
> @@ -87,7 +87,7 @@ class Port(object):
>          return {'dpid': dpid_to_str(self.dpid),
>                  'port_no': port_no_to_str(self.port_no),
>                  'hw_addr': self.hw_addr,
> -                'name': self.name.rstrip('\0')}
> +                'name': self.name.decode('UTF-8').rstrip('\0')}
>  
>      # for Switch.del_port()
>      def __eq__(self, other):

Hi,

I think it's better to pass text_type to Port.__init__.

How about changing Switches._get_switch to the following?
(I haven't tested at all)

    def _get_switch(self, dpid):
        if dpid in self.dps:
            switch = Switch(self.dps[dpid])
            for ofpport in self.port_state[dpid].values():
                switch.add_port(six.text_type(ofpport, 'utf-8'))
            return switch

--
IWAMOTO Toshihiro

------------------------------------------------------------------------------
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel

Reply via email to