> On Feb 26, 2016, at 12:12 AM, IWAMOTO Toshihiro <[email protected]> wrote: > > From the eventlet code, acquire() has no chance to return other than > True. I think such an assert statement with a side-effect should be > avoided in general. Things will break when someone decides to turn on > optimization and assert()s are disabled. (With python, it's "-O" > option.) >
Well - it's possible for acquire() to return False, but not in the way I'm calling it, so you're right. I apparently misunderstood the behavior of how "assert" works; I'll remove that. Thanks! > This patch does > * place semaphore calls around the event queue > * add an echo request keep-alive timer > * other unrelated cleanups > > I think it's optional but separating these things into different > patches is good. Also please write commit messages that concisely > describe the changes and your problem, not changelog from older > patchsets. > So: 1) I'll endeavor to keep the commit messages concise and independent. I've been doing "changelogs" since these have been iterations on the same patch. 2) Let me see what I can do about splitting these into a series of patches, and re-submitting. Best, Victor -- Victor J. Orlikowski <> vjo@[cs.]duke.edu ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
