I normally do "git commit -m" from the command line - so I did not necessarily notice the commit message length; my apologies. I'm not quite sure what to do about correcting them after the fact, though.
That said, that's not related to the content of the patch, right? Ditto re: the subject of the patch submission; I was trying to make clear that not all of the individual components of the patchset are idempotent. Some of them, however, are. Otherwise, hooray! Thanks for the review! Best, Victor -- Victor J. Orlikowski <> vjo@[cs.]duke.edu > On Feb 29, 2016, at 6:24 PM, IWAMOTO Toshihiro <[email protected]> wrote: > > Please line-wrap commit messages at ~70 characters. > Also "should be applied in order." in the subject seems redundant. > Otherwise, the patchset seems fine in general. ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
