Thank you for review. On Thu, 09 Jun 2016 17:25:21 +0900 IWAMOTO Toshihiro <[email protected]> wrote:
> At Thu, 9 Jun 2016 15:19:30 +0900, > fumihiko kakuma wrote: > > > > Signed-off-by: Fumihiko Kakuma <[email protected]> > > View objects work fine for for statements. > Do we need this patch? Yes, however there is another itervalues() as a method which return a iterator. So I thought that values() method is expected to return list. > > > --- > > ryu/services/protocols/bgp/info_base/base.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ryu/services/protocols/bgp/info_base/base.py > > b/ryu/services/protocols/bgp/info_base/base.py > > index da1a480..4585f15 100644 > > --- a/ryu/services/protocols/bgp/info_base/base.py > > +++ b/ryu/services/protocols/bgp/info_base/base.py > > @@ -82,7 +82,7 @@ class Table(object): > > raise NotImplementedError() > > > > def values(self): > > - return self._destinations.values() > > + return list(self._destinations.values()) > > > > def itervalues(self): > > return iter(self._destinations.values()) > > -- > > 1.9.1 > > -- > IWAMOTO Toshihiro > > ------------------------------------------------------------------------------ > What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic > patterns at an interface-level. Reveals which users, apps, and protocols are > consuming the most bandwidth. Provides multi-vendor support for NetFlow, > J-Flow, sFlow and other flows. Make informed decisions using capacity > planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e > _______________________________________________ > Ryu-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ryu-devel -- fumihiko kakuma <[email protected]> ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
