Hi Iwase,
Taking on board Victor's comments I made the following changes to my manager.py
file...
LOG = logging.getLogger('ryu.cmd.manager')
if CONF.enable_debugger:
msg = 'debugging is available (--enable-debugger option is turned on)'
LOG.info(msg)
else:
hub.patch(thread=True)
...
try:
hub.joinall(services)
except KeyboardInterrupt:
LOG.debug("Keyboard Interrupt received - RYU application manager
closing")
finally:
app_mgr.close()
Is this something you would consider including in the next RYU release?
Thanks again,
Alan.
-----Original Message-----
From: [email protected] [mailto:[email protected]]
Sent: Wednesday, July 20, 2016 11:39 AM
To: [email protected]
Cc: [email protected]
Subject: Re: [Ryu-devel] KeyboardInterrupt (ctrl-c) and RYU
Your suggestion of a log message is probably the best approach.
Thanks,
Alan.
-----Original Message-----
From: Victor Orlikowski [mailto:[email protected]]
Sent: Wednesday, July 20, 2016 11:36 AM
To: FORDYCE,ALAN (K-Scotland,ex1) <[email protected]>
Cc: [email protected]
Subject: Re: [Ryu-devel] KeyboardInterrupt (ctrl-c) and RYU
Also - should be obvious - but include a comment on the pass, explaining that
you're "papering over" the fact that eventlet doesn't properly wrap the
KeyboardInterrupt inside select()/poll()/epoll().
Another suggestion: instead of a pass, a log message, at debug level (or
whatever desired default priority), that notes that Ctrl-C was received and
applications are terminating.
Best,
Victor
--
Victor J. Orlikowski <> vjo@[cs.]duke.edu
> On Jul 20, 2016, at 11:20 AM, Victor Orlikowski <[email protected]> wrote:
>
> Suggest just silently swallowing the KeyboardInterrupt (with a "pass"), since
> the finally block will cover the close().
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports.http://sdm.link/zohodev2dev
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports.http://sdm.link/zohodev2dev
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel
