Hi Fujita-San, Thank you for reviewing my patches.
On 2016年10月01日 20:18, FUJITA Tomonori wrote: > On Mon, 26 Sep 2016 13:59:53 +0900 > IWASE Yusuke <[email protected]> wrote: > >> This patch enhances the APIs of BGPSpeaker class which call >> 'operator.show' APIs. >> >> Note: This patch renames the following argument for the consistency >> of APIs. >> - argument 'family' of rib_get() to 'route_family' > > I think that 'family' is more appropriate. > > https://www.juniper.net/documentation/en_US/junos13.3/topics/reference/configuration-statement/family-edit-protocols-bgp.html > > Ryu uses the 'route family' word at some places but it's not used > generally. Okay, I will fix my patch to leave this argument name 'family'. > >> - argument 'routetype' of neighbor_get() to 'neighbor_get' > > What does 'routetype' represent? 'routetype' represents the type of RIB (Adj-RIB-In, Adj-RIB-Out), I guess. neighbor_get() seems to return the Adj-RIB-In info if routetype='received-routes', and the Adj-RIB-Out info if routetype='sent-routes'. https://github.com/iwaseyusuke/ryu/commit/cc544c8deac44a26df67fb23ab2d95440ac94fa6 Regards, Iwase ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
