On Wed, 05 Oct 2016 15:56:43 +0200
Michał Rzepka <[email protected]> wrote:

> The patch resolves issue experienced when decoding certain values of 
> name field in OFPMP_PORT_DESCRIPTION body. Non-decodable bytes are 
> replaced with utf-8 replacement character.
> 
> This issue was observed while retrieving OFPMP_PORT_DESC reply from 
> OpenFlow 1.3 compliant HP switch. One of ofp_struct structures 
> describing OFPP_LOCAL port has a name field with value 4f 46 50 50 5f 4c 
> 4f 43 41 4c 00 81 ff ff ff ff that translates to OFPP_LOCAL....... 
> Attempt to decode the value, as in modified line, raises an exception 
> "UnicodeDecodeError: 'utf8' codec can't decode byte 0x81 in position 11: 
> invalid start byte". In the submitted patch, non-decodable characters 
> are replaced with utf-8 REPLACEMENT CHARACTER (U+FFFD), which is 
> sufficient for the get_port_desc method to work seamlessly. Similar 
> usages of str.decode method may be found in ofctl_v1_3, ofctl_v1_4, 
> ofctl_v1_5 and need to be fixed in the future.
> 
> Signed-off-by: Michal Rzepka <[email protected]>
> ---
>   ryu/lib/ofctl_v1_3.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks!

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel

Reply via email to