Hi Fujita-San, Thank you for reviewing my patch.
On 2016年10月25日 22:36, FUJITA Tomonori wrote: > On Fri, 21 Oct 2016 17:02:30 +0900 > IWASE Yusuke <[email protected]> wrote: > >> This patch adds UT cases using Docker for ryu.lib.ovs. >> If Docker is not available, these tests will be skipped. >> >> Signed-off-by: IWASE Yusuke <[email protected]> >> --- >> .travis.yml | 7 +- >> ryu/tests/docker/mininet/Dockerfile | 21 + >> ryu/tests/docker/mininet/ENTRYPOINT.sh | 7 + >> ryu/tests/unit/__init__.py | 6 + >> ryu/tests/unit/lib/ovs/__init__.py | 0 >> ryu/tests/unit/lib/ovs/test_vsctl.py | 783 >> +++++++++++++++++++++++++++++++++ >> 6 files changed, 823 insertions(+), 1 deletion(-) >> create mode 100644 ryu/tests/docker/mininet/Dockerfile >> create mode 100644 ryu/tests/docker/mininet/ENTRYPOINT.sh >> create mode 100644 ryu/tests/unit/lib/ovs/__init__.py >> create mode 100644 ryu/tests/unit/lib/ovs/test_vsctl.py > > Great! But running this unconditionally with Docker installed sounds > too big burden. How about having this as a script for CI instead of > UT? This UT will be skipped if Docker has not been installed, but still burden? Also, this UT is depending on only Docker (service and CLI), but not depending on other extra requirements. The reason I put this into UT is the ease of visualizing the coverages including other test cases at https:/coveralls.io. Having scripts is also available, but can we combine the coverages of UTs and these scripts? Regards, Iwase ------------------------------------------------------------------------------ The Command Line: Reinvented for Modern Developers Did the resurgence of CLI tooling catch you by surprise? Reconnect with the command line and become more productive. Learn the new .NET and ASP.NET CLI. Get your free copy! http://sdm.link/telerik _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
