Hi Iwase-san, On Wed, 2 Nov 2016 16:51:35 +0900 IWASE Yusuke <[email protected]> wrote:
> Signed-off-by: IWASE Yusuke <[email protected]> > --- > ryu/tests/integrated/common/docker_base.py | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) > > diff --git a/ryu/tests/integrated/common/docker_base.py > b/ryu/tests/integrated/common/docker_base.py > index 13fe223..fd3ceef 100644 > --- a/ryu/tests/integrated/common/docker_base.py > +++ b/ryu/tests/integrated/common/docker_base.py > @@ -196,25 +196,28 @@ class DockerImage(object): > def create_ryu(self, tagname='ryu', image=None, check_exist=False): > if check_exist and self.exist(tagname): > return tagname > - workdir = TEST_BASE_DIR + '/' + tagname > + workdir = '%s/%s' % (TEST_BASE_DIR, tagname) > workdir_ctn = '/root/osrg/ryu' > - pkges = 'telnet tcpdump iproute2 ' > - pkges += 'gcc python-pip python-dev libffi-dev libssl-dev' > + pkges = 'telnet tcpdump iproute2' > + pkges += ' gcc python-dev libffi-dev libssl-dev' > + pkges += ' libxml2-dev libxslt1-dev zlib1g-dev' > if image: > use_image = image > else: > use_image = self.baseimage > c = CmdBuffer() > - c << 'FROM ' + use_image > + c << 'FROM %s' % use_image > c << 'RUN apt-get update' > - c << 'RUN apt-get install -qy --no-install-recommends ' + pkges > - c << 'RUN pip install -U six paramiko msgpack-rpc-python' > - c << 'ADD ryu ' + workdir_ctn > - install = 'RUN cd %s && pip install -r tools/pip-requires ' % > workdir_ctn > - install += '&& python setup.py install' > + c << 'RUN apt-get install -qy --no-install-recommends %s' % pkges > + c << 'ADD ryu %s' % workdir_ctn > + install = 'RUN cd %s' % workdir_ctn > + install += ' && pip install' > + install += ' -r tools/pip-requires' > + install += ' -r tools/test-requires' Why do we need the test-requires to run a ryu app on a container? I think that we may need a pip-requires which some packages are added or an another required file. And the above Dockerfile seems to faile in a case not to use osrg/ryu image. But we may not need that case. > + install += ' && python setup.py install' > c << install > > - self.cmd.sudo('rm -rf ' + workdir) > + self.cmd.sudo('rm -rf %s' % workdir) > self.cmd.execute('mkdir -p ' + workdir) > self.cmd.execute("echo '%s' > %s/Dockerfile" % (str(c), workdir)) > self.cmd.execute('cp -r ../ryu %s/' % workdir) > -- > 2.7.4 > > > ------------------------------------------------------------------------------ > Developer Access Program for Intel Xeon Phi Processors > Access to Intel Xeon Phi processor-based developer platforms. > With one year of Intel Parallel Studio XE. > Training and support from Colfax. > Order your platform today. http://sdm.link/xeonphi > _______________________________________________ > Ryu-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ryu-devel -- fumihiko kakuma <[email protected]> ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
