This patch fixes to check if the parsed protocols list contains the BGP message as expected.
Signed-off-by: IWASE Yusuke <iwase.yusu...@gmail.com> --- ryu/tests/unit/packet/test_bgp.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/ryu/tests/unit/packet/test_bgp.py b/ryu/tests/unit/packet/test_bgp.py index 2ab213c..a3c922f 100644 --- a/ryu/tests/unit/packet/test_bgp.py +++ b/ryu/tests/unit/packet/test_bgp.py @@ -24,6 +24,7 @@ import unittest from nose.tools import eq_ from nose.tools import ok_ +from ryu.utils import binary_str from ryu.lib import pcaplib from ryu.lib.packet import packet from ryu.lib.packet import bgp @@ -263,10 +264,15 @@ class Test_bgp(unittest.TestCase): LOG.debug('*** testing %s ...', f) for _, buf in pcaplib.Reader( open(BGP4_PACKET_DATA_DIR + f + '.pcap', 'rb')): + # Checks if BGP message can be parsed as expected. pkt = packet.Packet(buf) - LOG.debug(pkt) + ok_(isinstance(pkt.protocols[-1], bgp.BGPMessage), + 'Failed to parse BGP message: %s' % pkt) + + # Checks if BGP message can be serialized as expected. pkt.serialize() - eq_(buf, pkt.data) + eq_(buf, pkt.data, + "b'%s' != b'%s'" % (binary_str(buf), binary_str(pkt.data))) def test_json1(self): opt_param = [bgp.BGPOptParamCapabilityUnknown(cap_code=200, -- 2.7.4 ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ Ryu-devel mailing list Ryu-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ryu-devel