Hi,

Thank you for posting your code!

I've just posted the patch for your suggestion.
Could you review my patch?
  [Ryu-devel] [PATCH] lib/ofctl_v_*: Enable to filter flow stats by priority

Note: I dropped the matching against cookie field from your code, because the
filtering by cookie should be done on switches according to OpenFlow Spec.
Please refer to "7.3.5.2 Individual Flow Statistics" section on OpenFlow Spec
1.3.5 about matching rules against cookie/cookie_mask fields.

Thanks,
Iwase


On 2016年12月08日 15:20, ....... wrote:
> Hello, I am  TICOMM Information Technology Co. Ltd,Shenzhen, China
> It doesn't matter.Here's my patch bag.If ok, please email to all RYU 
> users,thanks.
> 
> 
> 
> 
> ------------------ 原始邮件 ------------------
> *发件人:* "Iwase Yusuke";<[email protected]>;
> *发送时间:* 2016年12月8日(星期四) 下午2:09
> *收件人:* "......."<[email protected]>;
> *抄送:* "ryu-devel"<[email protected]>;
> *主题:* Re: [Ryu-devel] 回复: 回复: 回复: RYU BUG
> 
> Hi,
> 
> Sorry the delay and if I'm misunderstanding.
> 
> You mean; if you sent the patches for this mailing list, you can
> not notice how this problem would be solved on Ryu, right?
> 
> Don't worry, I don't think so.
> We will discuss how to solve this problem on this mailing list
> and you can notice the applied patch on this mailing list and
> on GitHub page.
> We welcome you to join this mailing list.
> 
> Thanks,
> Iwase
> 
> 
> On 2016年12月06日 11:00, ....... wrote:
>> Hello, I am  TICOMM Information Technology Co. Ltd,Shenzhen, China
>> Our boss said that if we give you this patch package, you can not notice in 
>> your forum, and e-mail notification, is our company to help optimize the 
>> problem, ok?
>>
>>
>>
>> ------------------ 原始邮件 ------------------
>> *发件人:* "Iwase Yusuke";<[email protected]>;
>> *发送时间:* 2016年12月5日(星期一) 中午12:15
>> *收件人:* "......."<[email protected]>;
>> *抄送:* "ryu-devel"<[email protected]>;
>> *主题:* Re: [Ryu-devel] 回复: 回复: RYU BUG
>>
>> Hi,
>>
>>
>> On 2016年12月05日 12:33, ....... wrote:
>>> Hello, I am China Shenzhen TICOMM Information Technology Co. Ltd.
>>> we use  ofctl_rest.py file   exactly serach an flow table,example:
>>>
>>>
>>>
>>> we search this flow table  and cost 18-20s  return the result,but we fix it 
>>> and just cost 4-5s
>>
>> Oh, you already have a patch for this problem?
>> Sorry, I misunderstood.
>>
>> That sounds great patch!
>> Could you send your patch to this mailing list?
>>
>> Thanks,
>> Iwase
>>
>>
>>>
>>>
>>>
>>>
>>> ------------------ 原始邮件 ------------------
>>> 发件人: "Iwase Yusuke";<[email protected]>;
>>> 发送时间: 2016年12月5日(星期一) 上午10:39
>>> 收件人: "......."<[email protected]>;
>>> 抄送: "ryu-devel"<[email protected]>;
>>> 主题: Re: [Ryu-devel] 回复: RYU BUG
>>>
>>>
>>>
>>> Hi,
>>>
>>> You mean; getting FlowStats by using ofctl_rest.py takes too long. so this 
>>> is a bug, right?
>>>
>>> Hummm... unfortunately, ofctl_rest.py is just a sample application and 
>>> currently not targeting
>>> the performance.
>>> For usability and readableness, this app provides some features, but not be 
>>> optimized yet for
>>> speed.
>>>
>>> If you need more speed, how about writing your own Ryu Application?
>>>
>>> Thanks,
>>> Iwase
>>>
>>>
>>> On 2016年12月05日 11:13, ....... wrote:
>>>> Hello, I am China Shenzhen TICOMM Information Technology Co. Ltd.
>>>> What does "under the slow speed" exactly mean?
>>>> answer:The interval of we use ofctl_rest.py  file  exactly serach an flow 
>>>> table,
>>>> return result is very slow.(We used 8888 flow table tests)
>>>>
>>>>
>>>>
>>>> we use   ofctl_rest.py  file  providing api and we fix this bug of  
>>>> seraching speed is slow
>>>> #
>>>> # get flows stats of the switch filtered by the fields
>>>> # POST /stats/flow/<dpid>
>>>> #
>>>>
>>>>
>>>> ------------------ 原始邮件 ------------------
>>>> 发件人: "Iwase Yusuke";<[email protected]>;
>>>> 发送时间: 2016年12月5日(星期一) 上午8:46
>>>> 收件人: "......."<[email protected]>;
>>>> 抄送: "ryu-devel"<[email protected]>;
>>>> 主题: Re: [Ryu-devel] RYU BUG
>>>>
>>>>
>>>>
>>>> Hi,
>>>>
>>>> Thank you for your report.
>>>>
>>>>
>>>> On 2016年12月02日 21:06, ....... wrote:
>>>>> Hello, I am China Shenzhen TICOMM Information Technology Co. Ltd., I 
>>>>> found the flow table ofctl_rest.py
>>>>>  public module you in RYU, there is no exact match under the slow speed, 
>>>>> about 18 to 20 seconds, we have
>>>>>  to help you repair the bug, now under the flow table for about 4 to 5 
>>>>> seconds
>>>>
>>>> but...
>>>> What does "under the slow speed" exactly mean?
>>>> The wire rate of switch-controller link? The interval of FlowMod-FlowStats 
>>>> messages?
>>>>
>>>> Please tell us more about it.
>>>>
>>>> Thanks,
>>>> Iwase
>>>>
>>>>
>>>>>
>>>>>
>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> Check out the vibrant tech community on one of the world's most
>>>>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Ryu-devel mailing list
>>>>> [email protected]
>>>>> https://lists.sourceforge.net/lists/listinfo/ryu-devel
>>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> _______________________________________________
>>>> Ryu-devel mailing list
>>>> [email protected]
>>>> https://lists.sourceforge.net/lists/listinfo/ryu-devel
>>>>
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Ryu-devel mailing list
>>>> [email protected]
>>>> https://lists.sourceforge.net/lists/listinfo/ryu-devel
>>>>
>>>
>>> ------------------------------------------------------------------------------
>>> _______________________________________________
>>> Ryu-devel mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/ryu-devel
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>>
>>>
>>>
>>> _______________________________________________
>>> Ryu-devel mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/ryu-devel
>>>
>>
>> ------------------------------------------------------------------------------
>> _______________________________________________
>> Ryu-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/ryu-devel
>>
>>
>> ------------------------------------------------------------------------------
>> Developer Access Program for Intel Xeon Phi Processors
>> Access to Intel Xeon Phi processor-based developer platforms.
>> With one year of Intel Parallel Studio XE.
>> Training and support from Colfax.
>> Order your platform today.http://sdm.link/xeonphi
>>
>>
>>
>> _______________________________________________
>> Ryu-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/ryu-devel
>>
> 
> 
> ------------------------------------------------------------------------------
> Developer Access Program for Intel Xeon Phi Processors
> Access to Intel Xeon Phi processor-based developer platforms.
> With one year of Intel Parallel Studio XE.
> Training and support from Colfax.
> Order your platform today.http://sdm.link/xeonphi
> 
> 
> 
> _______________________________________________
> Ryu-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ryu-devel
> 

------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel

Reply via email to