On Fri, 6 Jan 2017 09:41:50 +0900 Iwase Yusuke <[email protected]> wrote:
> Hi, > > On 2017年01月06日 05:58, FUJITA Tomonori wrote: >> On Tue, 27 Dec 2016 21:45:17 +0100 >> Olivier DESNOE <[email protected]> wrote: >> >>> Following your comments, this 3rd version of the patch adds the ability to >>> dissect and generate DHCPv6 packets. >>> >>> Signed-off-by: Olivier DESNOE <[email protected]> >> >> Thanks a lot! >> >> Any comment, Iwase? > > This patch works as expected with sample pcap on Wireshark wiki. > https://wiki.wireshark.org/SampleCaptures Thanks for the confirmation. > But, a little... > >> +class option(stringify.StringifyMixin): >> + """DHCP (RFC 3315) options encoder/decoder class. >> + >> + This is used with ryu.lib.packet.dhcp6.dhcp6.options. >> + >> + An instance has the following attributes at least. >> + Most of them are same to the on-wire counterparts but in host byte >> order. >> + __init__ takes the corresponding args in this order. >> + >> + The format of DHCP options is: >> + >> + \ 0 1 2 3 >> + \ 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 >> + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ >> + | option-code | option-len | >> + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ >> + | option-data | >> + | (option-len octets) | >> + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ > > The above seems to be still corrupted on the documentation. > I built it on my repo: > > http://ryu-iwase.readthedocs.io/en/packet-dhcp6/library_packet_ref.html#ryu.lib.packet.dhcp6.option Can you send a fix? ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
