On Wed, 4 Jan 2017 10:09:16 +0900 Iwase Yusuke <iwase.yusu...@gmail.com> wrote:
> Hi Fujita-San, > > > On 2016年12月29日 22:53, FUJITA Tomonori wrote: >> On Tue, 20 Dec 2016 11:48:00 +0900 >> IWASE Yusuke <iwase.yusu...@gmail.com> wrote: >> >>> This patch re-implements utils.parse_requirements() without retrieving >>> code from OpenStack. >>> >>> Signed-off-by: IWASE Yusuke <iwase.yusu...@gmail.com> >>> --- >>> ryu/utils.py | 71 >>> ++++++++++++++++++++---------------------------------------- >>> 1 file changed, 24 insertions(+), 47 deletions(-) >> >> I'm happy to reuse the working code from other OSS projects as long as >> the license allows it. >> >> What's the advantage of this patch? > > I'm sorry I didn't explain enough. > > The trigger of this patch is that I found utils.parse_requirements() is not > used in Ryu components and there is almost the same functions is provided > in "pip" package (it supports more features, e.g., available to parse the > file on HTTP://...). > > So, I wanted remove this function at first, but for the backward compatibility > and supporting more features like pip.req.parse_requirements(). > Then, I re-implemented it. > > As a result, this patch removes all OpenStack's source, I committed with > just "without OpenStack's source" message. > I should have committed with "Enhance parse_requirements() using pip" or so. I see. Pushed, thanks! ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Ryu-devel mailing list Ryu-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ryu-devel
