Hi Mark,

As you pointed out, Ryu does not always send bitmaps of the supported version.
  https://github.com/osrg/ryu/blob/master/ryu/controller/controller.py#L369

But, OpenFlow Spec 1.3 says the bitmaps element is optional and the smaller
version should be negotiated if no bitmaps element provided.
So, your switch should select the OP1.3 as the negotiated version, I guess.

OTOH, Ryu can send the Hello messages, but the bitmaps element was introduced
at OF1.3.1.
I'm afraid that the Hello messages will cause the malformed message errors at
the switches which do not support the bitmaps element.


Thanks,
Iwase

On 2017年02月09日 12:31, mark wrote:
> Hi Dev,
> 
> sorry for provide wrong 'ofctl_rest.py', correct setting should be:
> 
> /*# supported ofctl versions in this restful app**
> **supported_ofctl = {**
> **    ofproto_v1_0.OFP_VERSION: ofctl_v1_0,**
> **    ofproto_v1_2.OFP_VERSION: ofctl_v1_2,**
> **    ofproto_v1_3.OFP_VERSION: ofctl_v1_3,**
> **    ofproto_v1_4.OFP_VERSION: ofctl_v1_4,**
> **    ofproto_v1_5.OFP_VERSION: ofctl_v1_5,*
> /
> 
> 
> BR<
> MARK
> 
> 
> On 2/9/17 11:05, mark wrote:
>>
>> Dear Dev,
>>
>> i test ryu v4.6 which support OF version to 1.4. below.
>>
>> /mark@RYU-4:~/ryu/ryu/app$ ryu-manager --version//
>> //ryu-manager 4.6/
>>
>> /< ofctl_rest.py >:
>> /
>>
>> /class RestStatsApi(app_manager.RyuApp):
>>     OFP_VERSIONS = [ofproto_v1_0.OFP_VERSION,
>>                     ofproto_v1_2.OFP_VERSION,
>>                     ofproto_v1_3.OFP_VERSION,
>>                     ofproto_v1_4.OFP_VERSION]/
>>
>> when i specify switch to use version=13, and run ofctl_rest.py, i got switch 
>> report error as 'version incompatible',
>>
>> /connected socket:<eventlet.greenio.base.GreenSocket object at 
>> 0x7f329d9c1f50> address:('10.1.9.43', 53256)//
>> //hello ev <ryu.controller.ofp_event.EventOFPHello object at 
>> 0x7f329d95a8d0>//
>> //move onto config mode//
>> //EventOFPErrorMsg received.//
>> //version=0x6, msg_type=0x1, msg_len=0x14, xid=0x5700e926//
>> // `-- msg_type: OFPT_ERROR(1)//
>> //OFPErrorMsg(type=0x0, code=0x0, data=b'\x06\x00\x00\x08\x57\x00\xe9\x26')//
>> // |-- type: OFPET_HELLO_FAILED(0)//
>> // |-- code: OFPHFC_INCOMPATIBLE(0)//
>> // `-- data: version=0x6, msg_type=0x0, msg_len=0x8, xid=0x5700e926//
>> //     `-- msg_type: OFPT_HELLO(0)//
>> //EVENT ofp_event->dpset EventOFPStateChange/
>>
>> i tshark and find switch do really send hello pkt with bitmap as 0x10, but 
>> ryu send back hello with version=0x06, no any 'bitmap' include.
>>
>>
>> could please help to verify this issue?
>>
>> PS. attached pcap file for reference.
>>
>> BR<
>> MARK
>>
> 
> 
> ====================================================================================
> This message may contain information which is private, privileged or 
> confidential of INNO-Tech Network & Service Inc.
> If you are not the intended recipient of this message, please notify the 
> sender and destroy/delete the message.
> Any review, retransmission, dissemination or other use of, or taking of any 
> action in reliance upon this information,
> by persons or entities other than the intended recipient is prohibited.
> ====================================================================================
> 
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> 
> 
> 
> _______________________________________________
> Ryu-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ryu-devel
> 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel

Reply via email to