Hi,
I've sent an updated version too via mail. Print statements should be
deleted there. The first version wasn't working properly with multiple
switches. Please refer to the pull request I've created on GitHub. It
should contain the correct version of the patch.
Tomas
On Oct 22, 2017 14:16, "Iwase Yusuke" <iwase.yusu...@gmail.com> wrote:
> Hi Tomas,
>
> Thank you for submitting your patch!
>
> May I hove some comments?
>
>
> > + @set_ev_cls(ofp_event.EventOFPPacketIn, MAIN_DISPATCHER)
> > + def _packet_in_handler(self, ev):
> > + msg = ev.msg
> > + datapath = msg.datapath
> > + ofproto = datapath.ofproto
> > + parser = datapath.ofproto_parser
> > + in_port = msg.match['in_port']
> > +
> > + print msg.match
>
> Should this print statement be removed? (for only debugging?)
>
>
> > +# Copyright (C) 2011 Nippon Telegraph and Telephone Corporation.
>
> Also, should the published year be updated to 2017?
>
>
> Thanks,
> Iwase
>
> On 2017年10月22日 07:04, Thomas Boros wrote:
> > Hi,
> >
> > please ignore my previus patch, it was just wrong. It wasn’t working
> properly with multiple swithces. Packet_in messeges were generated
> unnecessarily. Here is the updated version of the path.
> >
> > Tomas
> >
> >
> >
> >
> >
> >> On 21 Oct 2017, at 17:19, Thomas Boros <tomas.boro...@gmail.com> wrote:
> >>
> >> Hello,
> >>
> >> I’ve created a simple switch app with the openflow 1.5 support. Tested
> with mininet and latest ovs.
> >>
> >> Tomas<0001-Added-simple-switch-with-openflow-1.5-support.patch>
> >
> >
> >
> > ------------------------------------------------------------
> ------------------
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >
> >
> >
> > _______________________________________________
> > Ryu-devel mailing list
> > Ryu-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/ryu-devel
> >
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Ryu-devel mailing list
Ryu-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ryu-devel
