Hi

I couldn't load your application correctly because indentation seems not to be
sorted out...

OTOH, on my environment, I could get the "EventSwitchEnter" event as expected.


$ git diff
diff --git a/ryu/app/simple_switch_13.py b/ryu/app/simple_switch_13.py
index 06a5d0e..cac7fdb 100644
--- a/ryu/app/simple_switch_13.py
+++ b/ryu/app/simple_switch_13.py
@@ -21,6 +21,8 @@ from ryu.ofproto import ofproto_v1_3
 from ryu.lib.packet import packet
 from ryu.lib.packet import ethernet
 from ryu.lib.packet import ether_types
+from ryu.topology import api as topo_api
+from ryu.topology import event as topo_event


 class SimpleSwitch13(app_manager.RyuApp):
@@ -117,3 +119,7 @@ class SimpleSwitch13(app_manager.RyuApp):
         out = parser.OFPPacketOut(datapath=datapath, buffer_id=msg.buffer_id,
                                   in_port=in_port, actions=actions, data=data)
         datapath.send_msg(out)
+
+    @set_ev_cls(topo_event.EventSwitchEnter)
+    def _switch_enter_handler(self, ev):
+        self.logger.info(ev)


$ ryu-manager ryu/app/simple_switch_13.py
loading app ryu/app/simple_switch_13.py
loading app ryu.topology.switches
loading app ryu.controller.ofp_handler
instantiating app ryu.topology.switches of Switches
instantiating app ryu.controller.ofp_handler of OFPHandler
instantiating app ryu/app/simple_switch_13.py of SimpleSwitch13
EventSwitchEnter<dpid=1, 2 ports>
...(snip)...


First, please confirm "ryu.topology.switches" is loaded when starting your
application.

$ ryu-manager ryu/app/simple_switch_13.py
loading app ryu/app/simple_switch_13.py
loading app ryu.topology.switches      # <--- please confirm this
loading app ryu.controller.ofp_handler
...(snip)...


Thanks,
Iwase


On 2018年01月01日 16:10, Taha Khan wrote:
Hi Every One,

I am trying to write an application that does topology discovery.
I added the a function def get_topology_data at the end of my application
I ran the controller with the command: "ryu-manager ryu.app.myswitch --observe-links" and then the mininet with my custom. However, the event EventSwitchEnter is never triggered. Can you please let me know if i am missing something here?

My code is as follows:


from ryu.base import app_manager
from ryu.controller import ofp_event
from ryu.controller.handler import CONFIG_DISPATCHER, MAIN_DISPATCHER
from ryu.controller.handler import set_ev_cls
from ryu.ofproto import ofproto_v1_3
from ryu.lib.packet import packet
from ryu.lib.packet import ethernet
from ryu.lib.packet import ether_types
from ryu import utils
from ryu.lib.packet import ipv6
from ryu.lib import mac
from ryu.topology import event,switches
from ryu.topology.api import get_switch, get_link
import copy

class SimpleSwitch13(app_manager.RyuApp):
     OFP_VERSIONS = [ofproto_v1_3.OFP_VERSION]

     def __init__(self, *args, **kwargs):
         super(SimpleSwitch13, self).__init__(*args, **kwargs)
         self.mac_to_port = {}

     @set_ev_cls(ofp_event.EventOFPSwitchFeatures, CONFIG_DISPATCHER)
     def switch_features_handler(self, ev):
         datapath = ev.msg.datapath
         ofproto = datapath.ofproto
         parser = datapath.ofproto_parser
     msg=ev.msg

     #self.logger.info <http://self.logger.info>("Packet data: {}".format(msg))
         # install table-miss flow entry
         #
         # We specify NO BUFFER to max_len of the output action due to
         # OVS bug. At this moment, if we specify a lesser number, e.g.,
         # 128, OVS will send Packet-In with invalid buffer_id and
         # truncated packet data. In that case, we cannot output packets
         # correctly.  The bug has been fixed in OVS v2.1.0.
         match = parser.OFPMatch()
         actions = [parser.OFPActionOutput(ofproto.OFPP_CONTROLLER,
                                           ofproto.OFPCML_NO_BUFFER)]
         self.add_flow(datapath, 0, match, actions)
    #self.logger.info <http://self.logger.info>("Switch: {}".format(datapath.id <http://datapath.id>))

     def add_flow(self, datapath, priority, match, actions, buffer_id=None):
         ofproto = datapath.ofproto
         parser = datapath.ofproto_parser

         inst = [parser.OFPInstructionActions(ofproto.OFPIT_APPLY_ACTIONS,
                                              actions)]
         if buffer_id:
             mod = parser.OFPFlowMod(datapath=datapath, buffer_id=buffer_id,
                                     priority=priority, match=match,
                                     instructions=inst)
         else:
             mod = parser.OFPFlowMod(datapath=datapath, priority=priority,
                                     match=match, instructions=inst)
         datapath.send_msg(mod)

     @set_ev_cls(ofp_event.EventOFPPacketIn, MAIN_DISPATCHER)
     def _packet_in_handler(self, ev):
         # If you hit this you might want to increase
         # the "miss_send_length" of your switch
         if ev.msg.msg_len < ev.msg.total_len:
             self.logger.debug("packet truncated: only %s of %s bytes",
                               ev.msg.msg_len, ev.msg.total_len)
         msg = ev.msg
     datapath = msg.datapath
    #self.logger.info <http://self.logger.info>('Datapath: {}'.format(datapath.id <http://datapath.id>))
     ofproto = datapath.ofproto

     parser = datapath.ofproto_parser
     #self.logger.info <http://self.logger.info>('Parser: {}'.format(parser))


     if msg.reason == ofproto.OFPR_NO_MATCH:
         reason = 'NO MATCH'
         elif msg.reason == ofproto.OFPR_ACTION:
                 reason = 'ACTION'
         elif msg.reason == ofproto.OFPR_INVALID_TTL:
                 reason = 'INVALID TTL'
    #self.logger.info <http://self.logger.info>('OFPPacketIn received: buffer_id=%x total_len=%d reason=%s table_id=%d cookie=%d match=%s', msg.buffer_id, msg.total_len, reason, msg.table_id, msg.cookie, msg.match)
         in_port = msg.match['in_port']

     #open flow headers are parsed already

     pkt = packet.Packet(msg.data)
    #self.logger.info <http://self.logger.info>('Packet information {}'.format(pkt))
         eth = pkt.get_protocols(ethernet.ethernet)[0]
     dst = eth.dst
         src = eth.src

         dpid = datapath.id <http://datapath.id>

         if eth.ethertype == ether_types.ETH_TYPE_LLDP:  # ignore lldp packet
        #self.logger.info <http://self.logger.info>("LLDP packet in %s %s %s %s", dpid, src, dst, in_port)
         return



         self.mac_to_port.setdefault(dpid, {})

self.logger.info <http://self.logger.info>("packet in %s %s %s %s", dpid, src, dst, in_port)

     if dst[:5] == "33:33":  # ignore IPV6 multicast packet
          match = parser.OFPMatch(in_port=in_port,eth_dst=dst)
         actions=[]
         self.add_flow(datapath, 1 , match, actions)
         return

     if  dst==mac.BROADCAST_STR: # Handle ARP broadcast
self.logger.info <http://self.logger.info>('This is ARP broadcast received at port {} of switch {}'.format(in_port, datapath.id <http://datapath.id>) )
         #self.send_arpproxy()

   # This event is not triggered at all.
     @set_ev_cls(event.EventSwitchEnter)
         def get_topology_data(self, ev):
         # The Function get_switch(self, None) outputs the list of switches.
         self.topo_raw_switches = copy.copy(get_switch(self, None))
         # The Function get_link(self, None) outputs the list of links.
         self.topo_raw_links = copy.copy(get_link(self, None))

self.logger.info <http://self.logger.info>("****************THIS EVENT IS NOT TRIGGERRED***********")

         print(" \t" + "Current Links:")
         for l in self.topo_raw_links:
             print (" \t\t" + str(l))

         print(" \t" + "Current Switches:")
         for s in self.topo_raw_switches:
             print (" \t\t" + str(s))

         return

Thank you,
Taha




------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot



_______________________________________________
Ryu-devel mailing list
Ryu-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ryu-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Ryu-devel mailing list
Ryu-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ryu-devel

Reply via email to