Gaetan Bisson just informed me about an ArchLinux bug report, as above and, including story and patch, below. S-nail needs a subminor update because of me.
This week i also stumbled over some ugly behaviour when `#NO' message attachments are deselected and "replaced" with a regular file attachment, which will result in a faulty `Content-Description' MIME header for the attachment (still stating "Attached message content"), and i want to get that right, too. I'm spending tomorrow on that and release a v14.6.3 afterwards. Thanks, sorry and ciao, --steffen Author: Steffen (Daode) Nurpmeso <[email protected]> Date: 2014-04-04 20:44:56 +0200 main(): fix argument parsing (Gaetan Bisson).. With our builtin getopt parser usage of the -L option would have resulted in a crash, as reported by an ArchLinux user in https://bugs.archlinux.org/task/39742 I've introduced this bug in [e82b6be] (Move our getopt to main.c, fix AMALGAMATION on GNU systems!, 2013-12-18), which localized our getopt in main.c -- my static naming scheme of variables let names start with an underscore, i thus renamed all the variable occurrences. When i've implemented the -L option i obviously have forgotten about all that and used `optarg' just as "normal" in POSIX C. It doesn't cause linker errors anywhere, but of course accessing an uninitialized variable is no good. diff --git a/main.c b/main.c index 6d9ffc2..66e5379 100644 --- a/main.c +++ b/main.c @@ -674,7 +674,7 @@ main(int argc, char *argv[]) okey = "ignore"; goto joarg; case 'L': - Larg = optarg; + Larg = _oarg; if (*Larg == '"' || *Larg == '\'') { /* TODO list.c:listspec_check() */ size_t j = strlen(++Larg); if (j > 0) ------------------------------------------------------------------------------ _______________________________________________ S-nail-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/s-nail-users
