I wrote: |After about fourteen (sixteen less two) months of development |i have merged into [master] the current state of affairs. ... | Preview 3, 2016-12-31:
I want to express my deepest regrets that replying to multipart mails with -pre3 will pretty much always causes a segmentation fault. I can assure you that the idea which effectively caused the bug to be introduced is a really good one, in my humble opinion. It was a little thought, but it seemed to cross my mind almost context-free. So the pretty much one line fix for this is now on [master] and below. And apologizing the undergone. Ciao. commit 893345bb Author: Steffen (Daode) Nurpmeso <[email protected]> AuthorDate: 2017-01-02 13:57:39 +0100 Commit: Steffen (Daode) Nurpmeso <[email protected]> CommitDate: 2017-01-02 14:00:01 +0100 FIX [1e5697d6] as of -12-22!.. Yes, it is a much better strategy to do so, but that does not mean that all messages come with a charset= parameter. Please do not crash, shall that happen. --- cmd_resend.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/cmd_resend.c b/cmd_resend.c index 055c094a..09530691 100644 --- a/cmd_resend.c +++ b/cmd_resend.c @@ -147,11 +147,12 @@ make_ref_and_cs(struct message *mp, struct header *head) /* TODO rewrite FAST */ head->h_ref = n; if (ok_blook(reply_in_same_charset) && (cp = hfield1("content-type", mp)) != NULL){ - char *cpo, c; + if((head->h_charset = cp = mime_param_get("charset", cp)) != NULL){ + char *cpo, c; - head->h_charset = cp = mime_param_get("charset", cp); - for(cpo = cp; (c = *cpo) != '\0'; ++cpo) - *cpo = lowerconv(c); + for(cpo = cp; (c = *cpo) != '\0'; ++cpo) + *cpo = lowerconv(c); + } } jleave: NYD_LEAVE; --steffen ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot __________________________________ [email protected]
