Hi Matthieu Agreed. I ll look into that and fix it.
Thanks Karthik PS: It might take a little bit as I haven't used JUnit before, this actually is the first time I wrote a test. Perils of academic work :-) On Thu, Oct 20, 2011 at 3:24 AM, Matthieu Morel <[email protected]>wrote: > Hi Karthik and Leo, > > I had a quick look at the pull request. It's an excellent idea to add such > a > test. However, I am concerned about the approach taken: the test is a java > app with a main method. If you expect developers to evaluate that the test > passes by reading the output on the console, that's unrealistic. > > Can you refactor the test by using JUnit, as in the other existing tests? > The idea is to validate the test through assertions. There are already > examples in the S4 codebase. > > Thanks, > > Matthieu > > On Thu, Oct 20, 2011 at 4:00 AM, Leo Neumeyer <[email protected]> > wrote: > > > DONE. Thanks! > > > > On Oct 19, 2011, at 6:15 PM, Karthik Kambatla wrote: > > > > > Hi Leo > > > > > > I have sent you a pull request - > > https://github.com/leoneu/s4-piper/pull/4 - > > > to test the basic functionality of s4-comm protocols. It has only a wee > > bit > > > of code, as I wanted to get a hang of the whole pull and merge process. > > :) > > > Let me know if I should be any more thorough with anything else. > > > > > > Thanks > > > Karthik > > > > >
