[
https://issues.apache.org/jira/browse/S4-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133070#comment-13133070
]
Leo Neumeyer commented on S4-12:
--------------------------------
I missed your earlier pull request, sorry about that. The isTrigger method in
ProcessingElement is pretty neat! Merged done.
> Dynamic Method Dispatching
> --------------------------
>
> Key: S4-12
> URL: https://issues.apache.org/jira/browse/S4-12
> Project: Apache S4
> Issue Type: Bug
> Environment: Matthieu, in ProcessingElement, I think you need to make
> the trigger map key dynamic, no? The trigger object is stored using the Event
> class as key which means that for CounterEvent, the key should be
> CounterEvent.class.
> private boolean isTrigger(Event event) {
> /* Check if there is a trigger for this event type. */
> Trigger trigger = triggers.get(Event.class); // TODO: modify for
> dynamic
> // dispatch.
> if (trigger == null)
> return false;
> /*
> * Check if it is time to activate the trigger for this event type.
> */
> return trigger.checkAndUpdate();
> }
> Reporter: Leo Neumeyer
> Assignee: Matthieu Morel
> Fix For: 0.5
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
