[
https://issues.apache.org/jira/browse/S4-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173985#comment-13173985
]
Matthieu Morel commented on S4-33:
----------------------------------
You're right, only some of the fixtures need to be moved to s4-comm. Maybe you
could rename util classes to CoreTestUtils and CommTestUtils.
What do you mean by "doesn't understand symbols"?
Doesn't s4-core already depends on s4-comm ? Anyway, it would be nicer to have
zk dependencies only from s4-comm but really, it isn't a big deal if you
introduce those dependencies for fixtures in s4-base, since it's only for tests.
> s4-comm tests should use zookeeper
> ----------------------------------
>
> Key: S4-33
> URL: https://issues.apache.org/jira/browse/S4-33
> Project: Apache S4
> Issue Type: Sub-task
> Affects Versions: 0.5
> Reporter: Karthik Kambatla
> Fix For: 0.5
>
>
> [From Skype call on 12/20] s4-comm tests currently use file-based
> configurations - AssignmentFromFile, TopologyFromFile. Instead, they should
> change to using zookeeper-based configurations.
> Steps involved --
> 1. Move org.apache.s4.fixtures from s4-core/test to s4-comm/test to avoid
> duplication of code
> 2. Rewrite s4-comm/tests to use these fixtures.
> Issues --
> 1. s4.fixtures uses some App-related code
> Eager to hear comments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
