[
https://issues.apache.org/jira/browse/S4-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501852#comment-13501852
]
Daniel Gómez Ferro commented on S4-25:
--------------------------------------
The patch looks good and it works perfectly. Great feature!
I just have a couple of minor comments:
There is a Thread.sleep(10000) in S4ApplicationMaster.main() which I don't
think it's needed.
For the memory, I'd let the user set it. It he doesn't, I'd just scale the
memory reserved for the container by a fixed factor, maybe 0.8. So, for the
-Xmx parameter I'd use a different parameter (-jvmMemory, -nodeMemory?) and if
it's not set use containerMemory * 0.8.
I think that YARN stopping only the application master is a YARN bug. I'd open
a ticket, if it turns out there's a better way to stop it they'll tell us.
> Write S4 Application Master to deploy S4 in Yarn
> ------------------------------------------------
>
> Key: S4-25
> URL: https://issues.apache.org/jira/browse/S4-25
> Project: Apache S4
> Issue Type: New Feature
> Reporter: J Mohamed Zahoor
> Fix For: 0.6
>
> Attachments: S4-ApplicationMaster.diff, S4-Client.diff,
> S4-Constants.diff, S4-YARN-1.patch
>
>
> On the lines of s4PigWrapper, write a s4 application master to host s4 piper
> inside Hadoop Yarn. This could be useful not only for reading data stored in
> hadoop ( to build or train a model)... But we could make use of the resource
> manager to deploy s4 instances in remote machine and monitor them. In short,
> we could make use of most of the resource management , scheduling and other
> good stuff in Yarn.
> - Yarn is useful to deploy and launch s4 instances.
> - It still requires deploying node managers on each box which means it will
> be useful if one is running more than one s4 process on a node.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
