[
https://issues.apache.org/jira/browse/S4-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559598#comment-13559598
]
Daniel Gómez Ferro commented on S4-59:
--------------------------------------
I have some more comments:
# The ZkServer.clean flag has been changed to false by default, which is less
comfortable for testing purposes. We could change the flag to -dontClean or
similar, but I don't have a strong preference.
# The field which stored the app name in ZK used to be called just "name".
AppConfig.APP_NAME is "appName" instead. There are several places that use the
old field name directly, should be changed to use AppConfig.APP_NAME.
#* subprojects/s4-core/src/main/java/org/apache/s4/core/S4Bootstrap.java:
String appName = appData.getSimpleField("name");
#* subprojects/s4-tools/src/main/java/org/apache/s4/tools/Status.java:
return appRecord.getSimpleField("name");
#* subprojects/s4-tools/src/main/java/org/apache/s4/tools/Status.java:
app.name = appRecord.getSimpleField("name");
# org.apache.s4.core.Main has been removed but it's referenced in a couple of
places
#* subprojects/s4-tools/src/main/resources/templates/s4: java -cp `cat
classpath.txt` org.apache.s4.core.Main $@
#* test-apps/twitter-adapter/build.gradle:mainClassName =
"org.apache.s4.core.Main"
> Resource loading from the S4 node classpath
> -------------------------------------------
>
> Key: S4-59
> URL: https://issues.apache.org/jira/browse/S4-59
> Project: Apache S4
> Issue Type: Improvement
> Affects Versions: 0.5.0
> Reporter: Daniel Gómez Ferro
> Assignee: Matthieu Morel
> Fix For: 0.6
>
>
> There should be a way to add custom files to the application's Classpath.
> This is useful to configure the logging backend, for example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
