Hi Matthieu/Kishore/Daniel I finally got around to porting UDP to use Netty. In the process, I had to factor out bulk of TCPEmitter/Listener to NettyEmitter/Listener to make sure we reuse as much code as possible.
When possible, will one of you be able to take a look. The special request is because I think it will be hard to keep up with any dev branch changes go into existing TCP Emitter/Listener code. Many thanks Karthik On Sat, Mar 2, 2013 at 8:36 PM, Karthik Kambatla <[email protected]> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9719/ > ----------------------------------------------------------- > > Review request for S4, Daniel Gómez Ferro, Matthieu Morel, and Kishore > Gopalakrishna. > > > Description > ------- > > The patch ports UDP also to use Netty. To reuse as much code as possible, > the patch moves bulk of what was TCPEmitter/TCPListener to > NettyEmitter/NettyListener. The protocol-specific implementations for TCP > and UDP extend the Netty abstract implementations. > > > This addresses bug S4-45. > https://issues.apache.org/jira/browse/S4-45 > > > Diffs > ----- > > subprojects/s4-base/src/main/java/org/apache/s4/base/Emitter.java 1f74381 > > subprojects/s4-comm/src/main/java/org/apache/s4/comm/netty/NettyEmitter.java > PRE-CREATION > > subprojects/s4-comm/src/main/java/org/apache/s4/comm/netty/NettyListener.java > PRE-CREATION > > subprojects/s4-comm/src/main/java/org/apache/s4/comm/tcp/DefaultRemoteEmitters.java > 151ad85 > subprojects/s4-comm/src/main/java/org/apache/s4/comm/tcp/TCPEmitter.java > fd0ad2b > > subprojects/s4-comm/src/main/java/org/apache/s4/comm/tcp/TCPListener.java > c7673ae > subprojects/s4-comm/src/main/java/org/apache/s4/comm/udp/UDPEmitter.java > d335970 > > subprojects/s4-comm/src/main/java/org/apache/s4/comm/udp/UDPListener.java > e719cbc > > subprojects/s4-comm/src/main/java/org/apache/s4/comm/udp/UDPRemoteEmitter.java > b1d1615 > > Diff: https://reviews.apache.org/r/9719/diff/ > > > Testing > ------- > > TCPBasicTest and UDPBasicTest pass in Eclipse. > > > Thanks, > > Karthik Kambatla > >
