+1 (non binding) * Signature and checksums match * Compiles and passes all tests * Twitter example runs * Created and ran new application * Src package matches git tag
Just a small comment regarding the tag in the repository. As discussed in the git-tag documentation [1] a tag shouldn't be renamed once it has been made public, since people that already have it in their local repo won't get an updated tag. Next time maybe it's better to create a tag per Release Candidate, and after it has been approved create the final one. Alternatively, we could refer to a specific commit in the voting email and tag the release after it's been approved. [1] https://www.kernel.org/pub/software/scm/git/docs/git-tag.html#_on_re_taggin g On 3/13/13 5:32 PM, "Matthieu Morel" <[email protected]> wrote: >Hello, > >this is the *second* release candidate for Apache S4, version 0.6.0 > >(we fixed 2 issues wrt RC1, related to s4 tools) > > >It fixes the following issues: >https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12312322&; >version=12321702 > > >*** Please download, test and vote by Monday March 18th 2013, 18.00 GMT > > >Note that we are voting upon the source (tag), binaries are provided for >convenience. > > >Source and binary packages in zip format: > >http://people.apache.org/~mmorel/s4-0.6.0-incubating-release-candidate-2/ > > > >The (git) tag to be voted upon: 0.6.0: > >https://git-wip-us.apache.org/repos/asf?p=incubator-s4.git;a=commit;h=0638 >a2a65f137485055fe9f1a9de386d88333e38 > > > >S4 KEYS file containing PGP keys we use to sign the release: > >http://svn.apache.org/repos/asf/incubator/s4/dist/KEYS > > >RAT tests require to get the .rat-excludes from the repository >(https://git-wip-us.apache.org/repos/asf?p=incubator-s4.git;a=blob;f=.rat- >excludes;h=fda230011164a53bd3089f9086c884918e0ea292;hb=refs/heads/dev) >and can be run with : >gradlew rat > output > > >Please cast your vote, thanks! > > >[ ] +1 approve >[ ] +0 no opinion >[ ] -1 disapprove (and reason why) > > > >NOTES (from the ASF website): > >- All votes are welcome, only Podling Project Management Committe (PPMC) >votes are binding, current PPMC = mentors + initial committers > >- All releases by podlings must be approved by the Incubator PMC. The >conventional process is for the podling to follow the usual Apache >process (including release vote, this one) and then call for a Incubator >PMC VOTE on the general incubator list. > >- Votes on whether a package is ready to be released use majority >approval -- i.e., at least three PMC members must vote affirmatively for >release, and there must be more positive than negative votes. Releases >may not be vetoed. Before voting +1 PMC members are required to download >the signed source code package, compile it as provided, and test the >resulting executable on their own platform, along with also verifying >that the package meets the requirements of the ASF policy on releases.
