On Sat, Mar 23, 2013 at 1:21 PM, Matthieu Morel <[email protected]> wrote: > The RAT tool says "Generated files do not required license headers". > > The scripts you are referring to are generated during the build. No one wrote > them, and they are derived from files which contain proper headers. > The gradlew script file at the root of the source distribution is also > generated (for being able to run gradle, and it is generated from gradle, > which is itself licensed with ASL2). > > Given these explanations, do you maintain your veto, or are we ok to > continue? In the later case, should I call a vote on general@incubator? How > many votes would we need?
Given they are generated and RAT is fine with it then I change my vote to +1. Everything else was fine except for that issue. It would be great though if you could either get the license header in the file, or at least a header that says that the file is generated (or did I miss that?) Patrick > > On Mar 22, 2013, at 23:49 , Patrick Hunt wrote: > >> -1 - the s4tools scripts in the bin directory of the bin artifact do >> not include license headers >> >> Patrick >> >> On Thu, Mar 21, 2013 at 9:13 AM, Flavio Junqueira <[email protected]> >> wrote: >>> +1, I have tested the src distribution and the bin package. I have also >>> checked the license file. great job! >>> >>> On Mar 21, 2013, at 4:43 PM, kishore g <[email protected]> wrote: >>> >>>> +1 >>>> >>>> Ran rat checks >>>> Few files missing AL, we can probably fix or update .rat-excludes file in >>>> next version >>>> !????? ./gradlew >>>> !????? ./gradlew.bat >>>> !????? ./lib/gradle-wrapper-1.4.properties >>>> !????? ./subprojects/s4-benchmarks/config/injector.config >>>> !????? ./subprojects/s4-benchmarks/config/node.config >>>> !????? ./subprojects/s4-tools/src/dist/gradlew >>>> !????? ./subprojects/s4-tools/src/dist/lib/gradle-wrapper-1.4.properties >>>> >>>> >>>> >>>> >>>> On Tue, Mar 19, 2013 at 4:31 AM, Daniel Gomez Ferro >>>> <[email protected]>wrote: >>>> >>>>> +1 (non binding) >>>>> >>>>> * Signature and checksums match >>>>> * Compiles and passes all tests >>>>> * Twitter example runs >>>>> * Created and ran new application >>>>> * Src package matches git tag >>>>> >>>>> >>>>> On 3/18/13 1:02 PM, "Matthieu Morel" <[email protected]> wrote: >>>>> >>>>>> Hello, >>>>>> >>>>>> this is the *third* release candidate for Apache S4, version 0.6.0 >>>>>> >>>>>> (we fixed 2 blocking issues wrt RC1, related to s4 tools, and 1 blocking >>>>>> issue in RC2, related to metrics logging configuration) >>>>>> >>>>>> >>>>>> It fixes the following issues: >>>>>> >>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12312322&; >>>>>> version=12321702 >>>>>> >>>>>> >>>>>> *** Please download, test and vote by Thursday March 21st 2013, 14.00 GMT >>>>>> >>>>>> >>>>>> Note that we are voting upon the source (tag), binaries are provided for >>>>>> convenience. >>>>>> >>>>>> >>>>>> Source and binary packages in zip format: >>>>>> >>>>>> http://people.apache.org/~mmorel/s4-0.6.0-incubating-release-candidate-3/ >>>>>> >>>>>> >>>>>> >>>>>> The (git) tag to be voted upon: 0.6.0-RC3: >>>>>> >>>>>> >>>>> https://git-wip-us.apache.org/repos/asf?p=incubator-s4.git;a=tag;h=9b17817 >>>>>> 0d76333579a9c56564dd060ccd173f115 >>>>>> >>>>>> >>>>>> >>>>>> S4 KEYS file containing PGP keys we use to sign the release: >>>>>> >>>>>> http://svn.apache.org/repos/asf/incubator/s4/dist/KEYS >>>>>> >>>>>> >>>>>> We include a RAT check task. It was updated after Patrick's comments and >>>>>> requires to get >>>>>> - the .rat-excludes from the repository >>>>>> ( >>>>> https://git-wip-us.apache.org/repos/asf?p=incubator-s4.git;a=blob;f=.rat- >>>>>> excludes;h=fda230011164a53bd3089f9086c884918e0ea292;hb=refs/heads/dev) >>>>>> - the rat jar from the repository >>>>>> It can be run with : >>>>>> gradlew rat > output >>>>>> >>>>>> >>>>>> Please cast your vote, thanks! >>>>>> >>>>>> >>>>>> [ ] +1 approve >>>>>> [ ] +0 no opinion >>>>>> [ ] -1 disapprove (and reason why) >>>>>> >>>>>> >>>>>> >>>>>> NOTES (from the ASF website): >>>>>> >>>>>> - All votes are welcome, only Podling Project Management Committe (PPMC) >>>>>> votes are binding, current PPMC = mentors + initial committers >>>>>> >>>>>> - All releases by podlings must be approved by the Incubator PMC. The >>>>>> conventional process is for the podling to follow the usual Apache >>>>>> process (including release vote, this one) and then call for a Incubator >>>>>> PMC VOTE on the general incubator list. >>>>>> >>>>>> - Votes on whether a package is ready to be released use majority >>>>>> approval -- i.e., at least three PMC members must vote affirmatively for >>>>>> release, and there must be more positive than negative votes. Releases >>>>>> may not be vetoed. Before voting +1 PMC members are required to download >>>>>> the signed source code package, compile it as provided, and test the >>>>>> resulting executable on their own platform, along with also verifying >>>>>> that the package meets the requirements of the ASF policy on releases. >>>>> >>>>> >>> >
