Dear Nicholas, On Sep 22, 5:23 am, "Nicolas M. Thiery" <nicolas.thi...@u-psud.fr> wrote: > > There is already a patch to fix this, namely > > > trac_6597_set_morphism_doc_pickling_extract.patch > > > but it has a guard of +4_1_1, and the current qselect is 4_1_2, so it > > doesn't get applied. Is this because the patch has not been reviewed > > yet, or is it just an oversight when changing the guards for the > > current milestone? > > Good job tracking this down; this is pretty tricky :-) In principle, > that was fixed two weeks ago: > > changeset 1699:9d173b1a529d: Fixed guard on #6597 which caused it not to > apply on 4.1.1 and broke algebras > > When did you last install/update?
I actually tried to report this before the problem was fixed, but it was my first post to the mailing list, so it was probably held in moderation for a while. I have just tried with the latest version of sage-combinat, and everything seems to work :-). > > As an aside for whoever is handling the .hg/patches/series file with > > all the guards, I would like to suggest that comments be preceded by a > > # character separate from the # character introducing guards. This is > > currently done for some of the comments, but not all. While it works > > the same either way for most hg commands, there is a significant > > difference when trying to change guards with hg qguard: the # > > characters introducing guards are removed along with the guards, and > > if other comments are not preceded by another # character, they become > > uncommented, and part of the file name that Mercurial looks for! > > Thanks for pointing this out. There indeed are a couple of them > left. Could you please fix them? We currently don't have a specific > policy for who does this: whoever needs (to fix) such a guard just > does it. I have now fixed the comments in the series file and pushed the changes to the server. (Sorry for the non-descriptive name for the changeset; this is my first time pushing to the server.) Cheers, Mathieu --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en -~----------~----~----~----~------~----~------~--~---
