Salut Nicolas, 2011/4/26 Nicolas M. Thiery <[email protected]>: > Salut Vincent, > > I just rebased your patch > > trac_10534-generation_of_subsets_and_set_partitions-vd.patch > > [...] > > Rationale: with #10534, TestSuite checks that cardinality returns an > Integer. So I had to fix Subsets(...).cardinality() accordingly, which > created a little conflict. I let you fix the new cardinality methods > in 11118. >
That's nice to have more tests. For the current problem, not all cardinalities (of subsets) are actually Integer... I will push a new version of the patch in few times (and write that it depends on 10534 on trac). I also add some TestSuite to the "degenrate guys": Subsets([],0), Subsets([1,2],8), ... to see (and it works). On the other hand, are there any convention for the place to put the TestSuite tests? I remember that test like "loads(dums(O)) == O" are better suited to be in the __init__ (because hidden to the user). What do you think about "TestSuite(O)" ? Vincent -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
