Hi Martin, > > Also, what's the right way to correct the qt_catalan doctest? > > sage: q_analogues.qt_catalan_number(1) > Expected: > 1 > Got: > doctest:178: DeprecationWarning: a_statistic is deprecated, use area > instead! > doctest:178: DeprecationWarning: b_statistic is deprecated, use bounce > instead! > 1 > > Thanks for your patience, >
You could just cut and paste the three lines after the Got: into q_analogues.py, replacing the "1" that is currently given at the output. A better fix would be to replace the calls to a_statistic and b_statistic with calls to area and bounce, respectively. For me, area bounce are not methods for DyckWords but for the patches you are running they must be. Thanks for posting the errors showing up in partition.py. It seems that you have an older version of the patch (which should have still passed the doc tests), or possibly a misapplied one. It should go away when you merge, but Anne says that my patch is not applying to version 5.2-rc0 so this migh be related even though you are running 5.1 Cheers, Andrew > > Martin > > sage -t "devel/sage-combinat/sage/combinat/partition.py" > ********************************************************************** > File > "/groups/comb/rubey/sage-5.1/devel/sage-combinat/sage/combinat/partition.py", > line 5347: > sage: > PartitionTuple([[3,3,2],[5,4,3,2]]).top_Garnir_tableau(2,(0,0,1)).pp() > Exception raised: > Traceback (most recent call last): > File "/groups/comb/rubey/sage-5.1/local/bin/ncadoctest.py", line > 1231, in run_one_test > self.run_one_example(test, example, filename, compileflags) > File "/groups/comb/rubey/sage-5.1/local/bin/sagedoctest.py", line > 38, in run_one_example > OrigDocTestRunner.run_one_example(self, test, example, filename, > compileflags) > File "/groups/comb/rubey/sage-5.1/local/bin/ncadoctest.py", line > 1172, in run_one_example > compileflags, 1) in test.globs > File "<doctest __main__.example_186[2]>", line 1, in <module> > > PartitionTuple([[Integer(3),Integer(3),Integer(2)],[Integer(5),Integer(4),Integer(3),Integer(2)]]).top_Garnir_tableau(Integer(2),(Integer(0),Integer(0),Integer(1))).pp()###line > > 5347: > sage: > PartitionTuple([[3,3,2],[5,4,3,2]]).top_Garnir_tableau(2,(0,0,1)).pp() > File > "/groups/comb/rubey/sage-5.1/local/lib/python/site-packages/sage/combinat/partition.py", > > line 5370, in top_Garnir_tableau > raise ValueError, '(row+1, col) must be inside the diagram' > ValueError: (row+1, col) must be inside the diagram > ********************************************************************** > File > "/groups/comb/rubey/sage-5.1/devel/sage-combinat/sage/combinat/partition.py", > line 5352: > sage: > PartitionTuple([[3,3,2],[5,4,3,2]]).top_Garnir_tableau(2,(1,0,1)).pp() > Exception raised: > Traceback (most recent call last): > File "/groups/comb/rubey/sage-5.1/local/bin/ncadoctest.py", line > 1231, in run_one_test > self.run_one_example(test, example, filename, compileflags) > File "/groups/comb/rubey/sage-5.1/local/bin/sagedoctest.py", line > 38, in run_one_example > OrigDocTestRunner.run_one_example(self, test, example, filename, > compileflags) > File "/groups/comb/rubey/sage-5.1/local/bin/ncadoctest.py", line > 1172, in run_one_example > compileflags, 1) in test.globs > File "<doctest __main__.example_186[3]>", line 1, in <module> > > PartitionTuple([[Integer(3),Integer(3),Integer(2)],[Integer(5),Integer(4),Integer(3),Integer(2)]]).top_Garnir_tableau(Integer(2),(Integer(1),Integer(0),Integer(1))).pp()###line > > 5352: > sage: > PartitionTuple([[3,3,2],[5,4,3,2]]).top_Garnir_tableau(2,(1,0,1)).pp() > File > "/groups/comb/rubey/sage-5.1/local/lib/python/site-packages/sage/combinat/partition.py", > > line 5370, in top_Garnir_tableau > raise ValueError, '(row+1, col) must be inside the diagram' > ValueError: (row+1, col) must be inside the diagram > ********************************************************************** > File > "/groups/comb/rubey/sage-5.1/devel/sage-combinat/sage/combinat/partition.py", > line 5357: > sage: > PartitionTuple([[3,3,2],[5,4,3,2]]).top_Garnir_tableau(3,(1,0,1)).pp() > Exception raised: > Traceback (most recent call last): > File "/groups/comb/rubey/sage-5.1/local/bin/ncadoctest.py", line > 1231, in run_one_test > self.run_one_example(test, example, filename, compileflags) > File "/groups/comb/rubey/sage-5.1/local/bin/sagedoctest.py", line > 38, in run_one_example > OrigDocTestRunner.run_one_example(self, test, example, filename, > compileflags) > File "/groups/comb/rubey/sage-5.1/local/bin/ncadoctest.py", line > 1172, in run_one_example > compileflags, 1) in test.globs > File "<doctest __main__.example_186[4]>", line 1, in <module> > > PartitionTuple([[Integer(3),Integer(3),Integer(2)],[Integer(5),Integer(4),Integer(3),Integer(2)]]).top_Garnir_tableau(Integer(3),(Integer(1),Integer(0),Integer(1))).pp()###line > > 5357: > sage: > PartitionTuple([[3,3,2],[5,4,3,2]]).top_Garnir_tableau(3,(1,0,1)).pp() > File > "/groups/comb/rubey/sage-5.1/local/lib/python/site-packages/sage/combinat/partition.py", > > line 5370, in top_Garnir_tableau > raise ValueError, '(row+1, col) must be inside the diagram' > ValueError: (row+1, col) must be inside the diagram > ********************************************************************** > 1 items had failures: > 3 of 6 in __main__.example_186 > ***Test Failed*** 3 failures. > For whitespace errors, see the file > /users/rubey/.sage//tmp/partition_20081.py > [14.8 s] > sage -t "devel/sage-combinat/sage/combinat/combinat.py" > [11.3 s] > sage -t "devel/sage-combinat/sage/combinat/perfect_matching.py" > [6.9 s] > sage -t "devel/sage-combinat/sage/combinat/tamari_lattices.py" > [4.1 s] > sage -t "devel/sage-combinat/sage/combinat/catalan_quasi_sym.py" > [3.5 s] > sage -t "devel/sage-combinat/sage/combinat/tableau_tuple.py" > [20.7 s] > sage -t "devel/sage-combinat/sage/combinat/q_analogues.py" > ********************************************************************** > File > "/groups/comb/rubey/sage-5.1/devel/sage-combinat/sage/combinat/q_analogues.py", > > line 157: > sage: q_analogues.qt_catalan_number(1) > Expected: > 1 > Got: > doctest:178: DeprecationWarning: a_statistic is deprecated, use area > instead! > doctest:178: DeprecationWarning: b_statistic is deprecated, use bounce > instead! > 1 > ********************************************************************** > 1 items had failures: > 1 of 9 in __main__.example_5 > ***Test Failed*** 1 failures. > For whitespace errors, see the file > /users/rubey/.sage//tmp/q_analogues_20239.py > [5.3 s] > -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To view this discussion on the web visit https://groups.google.com/d/msg/sage-combinat-devel/-/5RyU35AdRqYJ. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
