> > > ./modular/hecke/module.py: def is_zero(self): > > > > > > Does not inherit from Element. > > That thing inherits from Module, which is defined > in module.pyx. I think here we either don't have > an is_zero method in modulear/hecke/module.py > or we move it to modules/module.pyx, and define > __nonzero__ -- i.e., the same as was done for elements.
okay, will do. > > > ./structure/element.pyx: def is_zero(self): > > > > > > Does not inherit from Element. > > Um -- that is element ?? Huh? It doesn't inherit from itself ? Sorry, my bad, I was tired. > > > ./rings/morphism.py: def is_zero(self): > > > > > > Does not inherit from Element. > > That's bad. Ring morphisms are elements so should > inherit from element. That they don't is a mistake. I will check it. > > > ./rings/number_field/number_field_ideal.py: def is_zero(self): > > > ./rings/number_field/number_field_ideal.py: def is_zero(self): > > > > > > Does not inherit from Element. > > I think ideals should also be elements of a group of fraction ideals, > or at least of something. > > > > ./rings/padics/padic_lazy_element.py: def is_zero(self, prec): > > > ./rings/padics/padic_capped_relative_element.py: def is_zero(self, > > > prec = None): > > > ./rings/padics/padic_extension_generic_element.py: def is_zero(self, > > > prec): ./rings/padics/padic_ring_fixed_mod_element.py.orig: def > > > is_zero(self, prec = None): > > > ./rings/padics/local_generic_element.py: def is_zero(self, prec): > > > ./rings/padics/padic_ring_fixed_mod_element.py: def is_zero(self, > > > prec = None): > > > > > > Require additional prec parameter which doesn't fit into the > > > __nonzero__ concept, so I left it as is. Ideas? > > I think that should be left as is. At least I don't have any better ideas. > > William -- name: Martin Albrecht _pgp: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x8EF0DC99 _www: http://www.informatik.uni-bremen.de/~malb _jab: [EMAIL PROTECTED] --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://sage.scipy.org/sage/ and http://modular.math.washington.edu/sage/ -~----------~----~----~----~------~----~------~--~---
