I have added the following functionality to the mwrank package: * an interface to pari's isprime() function which (as we confirmed recently) really does provide a proof that primes are prime * integer factorization using the pari library is now followed by calling isprime() on the prime factors found * in the unlikely event that isprime() returns false on any of those (NB there are no known examples of this behaviour, according to the pari documentation, and it is proved not to happen for primes under 10^15) a WARNING is output to stderr.
Of course it would be prefereable to call factor() again instead of raising an error, but I don;t know if that would do anything at all, and in any case examples would be interesting to see. Now I have checked in those changes to my own CVS repository; I also created an hg repository as explained by William below -- doing this in my own source directory. SOrry to be stupid, but what next? (In the sage build directory I assume that the mwrank files exist somewhere, but I think only in a compressed tar file, so I have not changed those.) John On 9/7/07, William Stein <[EMAIL PROTECTED]> wrote: > > On 9/7/07, John Cremona <[EMAIL PROTECTED]> wrote: > > > > As a first attempt I was going to add the isprime() test to the > > factors returned and just output a warning if one of them fails. I > > guess that pari-dev would be interested in such examples anyway. > > > > BTW, not sure how I am supposed to provide patches to mwrank source > > code except by emailing the changes to William? Does one of the hg_* > > strands cover that? > > You should make an hg repository for mwrank itself. Just > go into the mwrank source directory, do > hg init > hg add the_files_that_you_want_under_revision_control > hg ci > and you're golden. Then whenever you make changes > do hg ci to check them in. You can browse history, revert > anything, etc. It's the way to go! > > And, when you want to make mwrank patches available to me > it's easy. > > William > > > > -- John Cremona --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://sage.scipy.org/sage/ and http://modular.math.washington.edu/sage/ -~----------~----~----~----~------~----~------~--~---
