Hi Dima, the patching that fails is only meant to make the docker image work in a local developer setup where you have your sage source tree (with changes and untracked files) mounted into the docker container. In the CI context the line that reads `git status --porcelain` in the Dockerfile should not return anything but it finds lots of unstaged changes. I guess that's something to do with some line endings.
I'll try to look into this tomorrow. julian On Wednesday, December 30, 2020 at 11:06:22 AM UTC+1 dim...@gmail.com wrote: > On Mon, Dec 28, 2020 at 10:05 PM Sebastian Oehms <seb....@gmail.com> > wrote: > > > > https://gitlab.com/sagemath/dev/trac/-/pipelines > > > so docker build does some patching (why? I don't know) and there are > failures (why? I don't know), > and then an attempt to do something with these rejected patches fails: > > cf. e.g. https://gitlab.com/sagemath/dev/trac/-/jobs/935852462 > > patching file src/sage/combinat/crystals/star_crystal.py > Reversed (or previously applied) patch detected! Assume -R? [n] > Apply anyway? [n] > Skipping patch. > 1 out of 1 hunk ignored -- saving rejects to file > src/sage/combinat/crystals/star_crystal.py.rej > patching file src/sage/ext_data/doctest/rich_output/example.png > patching file src/sage/ext_data/notebook-ipython/logo-64x64.png > patching file src/sage/misc/element_with_label.py > Reversed (or previously applied) patch detected! Assume -R? [n] > Apply anyway? [n] > Skipping patch. > 1 out of 1 hunk ignored -- saving rejects to file > src/sage/misc/element_with_label.py.rej > patching file src/sage/rings/invariants/__init__.py > Reversed (or previously applied) patch detected! Assume -R? [n] > Apply anyway? [n] > Skipping patch. > 1 out of 1 hunk ignored -- saving rejects to file > src/sage/rings/invariants/__init__.py.rej > The command '/bin/sh -c patch -p1 < "$HOME"/sage-context.patch' > returned a non-zero code: 1 > Command exited with non-zero status 1 > > I guess it's because it's a new codepath (with these rejected patches) in > docker/Dockerfile > > Over to Julian, I think. > > > > > On Mon, Dec 28, 2020 at 11:02 PM Sebastian Oehms <seb....@gmail.com> > wrote: > > > > > > Thanks to you both for the hints! Yes, instead of develop I used the > > > version tag directly. Running docker as you suggested solves the > > > problem. But, the version tag works on a newer CPU (the one causing > > > the crash was an i5 of the 2. generation), as well, and for 9.1.beta1 > > > even on the older CPU. > > > > > > What about my second point concerning the trac ticket branches, I mean > this? > > > > > > On Mon, Dec 28, 2020 at 9:49 PM Frédéric Chapoton <fchap...@gmail.com> > wrote: > > > > > > > > did you run > > > > > > > > docker run -it sagemath/sagemath-dev:develop > > > > > > > > or something else ? > > > > > > > > Le lundi 28 décembre 2020 à 12:45:20 UTC+1, seb....@gmail.com a > écrit : > > > >> > > > >> It seems that there is still (or again) something broken. For the > images of the beta releases since the 8th of December Sage crashes if I try > to start it: > > > >> > > > >> Sage build/upgrade complete! > > > >> make[1]: Leaving directory '/home/sage/sage' > > > >> sage@8711c66abafe:~/sage$ ./sage > > > >> > ┌────────────────────────────────────────────────────────────────────┐ > > > >> │ SageMath version 9.3.beta5, Release Date: 2020-12-27 │ > > > >> │ Using Python 3.8.5. Type "help()" for help. │ > > > >> > └────────────────────────────────────────────────────────────────────┘ > > > >> > ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓ > > > >> ┃ Warning: this is a prerelease version, and it may be unstable. ┃ > > > >> > ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛ > > > >> > ------------------------------------------------------------------------ > > > >> /home/sage/sage/local/lib/python3.8/site-packages/cysignals/ > signals.cpython-38-x86_64-linux-gnu.so(+0x6b28)[0x7ff042b33b28] > > > >> /home/sage/sage/local/lib/python3.8/site-packages/cysignals/ > signals.cpython-38-x86_64-linux-gnu.so(+0x6d08)[0x7ff042b33d08] > > > >> /home/sage/sage/local/lib/python3.8/site-packages/cysignals/ > signals.cpython-38-x86_64-linux-gnu.so(+0x93a0)[0x7ff042b363a0] > > > >> /lib/x86_64-linux-gnu/libpthread.so.0(+0x11390)[0x7ff0523f9390] > > > >> > /home/sage/sage/local/lib/libgmp.so.10(__gmpz_sizeinbase+0x47)[0x7ff049df0597] > > > > > >> /home/sage/sage/local/lib/python3.8/site-packages/sage/rings/ > rational.cpython-38-x86_64-linux-gnu.so(+0x1f78c)[0x7ff036e2978c] > > > >> /home/sage/sage/local/lib/python3.8/site-packages/sage/rings/ > rational.cpython-38-x86_64-linux-gnu.so(+0x370d5)[0x7ff036e410d5] > > > >> ............ > > > >> > /home/sage/sage/local/lib/libpython3.8.so.1.0(+0x185260)[0x7ff05278a260] > > > >> > /home/sage/sage/local/lib/libpython3.8.so.1.0(PyRun_FileExFlags+0x95)[0x7ff05278cb45] > > > > > >> > /home/sage/sage/local/lib/libpython3.8.so.1.0(PyRun_SimpleFileExFlags+0xf6)[0x7ff05278ccb6] > > > > > >> > /home/sage/sage/local/lib/libpython3.8.so.1.0(Py_RunMain+0x748)[0x7ff0527a7398] > > > > > >> > /home/sage/sage/local/lib/libpython3.8.so.1.0(Py_BytesMain+0x39)[0x7ff0527a77c9] > > > > > >> > /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0)[0x7ff05203e840] > > > >> python3(_start+0x29)[0x400709] > > > >> > ------------------------------------------------------------------------ > > > >> Attaching gdb to process id 9075. > > > >> Cannot find gdb installed > > > >> GDB is not installed. > > > >> Install gdb for enhanced tracebacks. > > > >> > ------------------------------------------------------------------------ > > > >> Unhandled SIGILL: An illegal instruction occurred. > > > >> This probably occurred because a *compiled* module has a bug > > > >> in it and is not properly wrapped with sig_on(), sig_off(). > > > >> Python will now terminate. > > > >> > ------------------------------------------------------------------------ > > > >> Illegal instruction (core dumped) > > > >> > > > >> Furthermore, all pipelines on individual branches since that date > failed. > > > >> > > > >> Frédéric Chapoton schrieb am Dienstag, 8. Dezember 2020 um 09:33:03 > UTC+1: > > > >>> > > > >>> the build for 9.3.beta3 has passed successfully, so there should > be a docker for that, and a docker for develop that should point to the > same. > > > >>> > > > >>> https://gitlab.com/sagemath/sage/-/pipelines > > > >>> > > > >>> Frédéric > > > >>> > > > >>> Le jeudi 15 octobre 2020 à 12:09:15 UTC+2, Sébastien Labbé a écrit > : > > > >>>> > > > >>>> Bonjour, > > > >>>> > > > >>>> Thanks to Vincent, I learned recently how to use continuous > integration in gitlab and the docker images of previous versions of sage > posted https://hub.docker.com/r/sagemath/sagemath-dev/ in order to test > that my optional package works with all those versions. It basically made > me realize that my package was broken on most versions of sage except the > most recent. And hopefully soon, I will be able to fix those issues. So > thanks to those involved in having these various docker images available. > > > >>>> > > > >>>> For the curious, the most recent run is available here: > > > >>>> https://gitlab.com/seblabbe/slabbe/-/pipelines/202932270 > > > >>>> it shows that my package works for 9.1.rc5 but not 9.0 or earlier > versions (I need to work on it). > > > >>>> > > > >>>> Unfortunately, it seems the docker images of various versions of > sage are not uploaded since 4 months. Maybe it was too much energy to > upload all beta versions there. In fact, I don't really need all beta in > there. What I think is important to have are the final releases. With that > respect, the following are missing: > > > >>>> > > > >>>> 8.6: ok > > > >>>> 8.7: ok > > > >>>> 8.8: ok > > > >>>> 8.9 is missing or is broken > > > >>>> 9.0 : ok > > > >>>> 9.1 is missing (so I am using 9.1.rc5 and 9.1.rc5-py3) > > > >>>> > > > >>>> No 9.2.betaX are there, but I would be happy that 9.2 be there > when released. > > > >>>> > > > >>>> Thanks to the people involved. > > > >>>> > > > >>>> Sincerely, > > > >>>> > > > >>>> Sébastien > > > > > > > > -- > > > > You received this message because you are subscribed to a topic in > the Google Groups "sage-devel" group. > > > > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/sage-devel/Dbd4nFi8R7I/unsubscribe. > > > > To unsubscribe from this group and all its topics, send an email to > sage-devel+...@googlegroups.com. > > > > To view this discussion on the web visit > https://groups.google.com/d/msgid/sage-devel/f00269b2-ce0d-4724-99b5-d8e97054679bn%40googlegroups.com. > > > > > > -- > > You received this message because you are subscribed to the Google > Groups "sage-devel" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to sage-devel+...@googlegroups.com. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/sage-devel/CAPEyD1D-p5x2MuB0K-7-Q88cAt0hzXYbovnrHh-tjH2_BVUtAA%40mail.gmail.com. > > > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/a598b42a-3cca-4539-8488-504f6c065078n%40googlegroups.com.
