Yes. This will be done in PR #36292 <https://github.com/sagemath/sage/pull/36292>.
Kwankyu Lee schrieb am Montag, 18. September 2023 um 03:07:14 UTC+2: > On Friday, September 8, 2023 at 5:47:30 PM UTC+9 seb....@gmail.com wrote: > > > I think this is too verbose. In particular, the message "kwankyu > requested changes for this PR" is redundant. > > From the point of view of a developer familiar with Trac status labels, I > agree. However, a key goal of the GitHub migration was to attract new > developers who are familiar with the GitHub workflow but have no knowledge > of Trac. The comment will show them that the label s: needs work is used > as a synonym for request changes. However, note that the comment is the > body of the request changes review which cannot be omitted: > > > OK. Shouldn't it be "@kwankyu"? > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/8aa64f02-b878-4e7d-9db1-975d9f57e63dn%40googlegroups.com.
