On Thu, Jul 23, 2009 at 1:22 AM, Dr. David
Kirkby<[email protected]> wrote:
>
> I've noticed a couple of issues on Solaris, where it appears packages
> have been installed properly (the $SAGE_HOME/spkg/installed/foobar is
> created), but this has not actually happened.
>
> On one occasion 'cp -a' was called, which failed to copy files to
> $SAGE_HOME/local/include, as '-a' is not an option on Solaris to the cp
> command. Sun's 'cp' reported this as an error, but this did not cause
> the 'make' to stop.
After every single command in spkg-install one *must* check the error
return value. That's why there is code like the following all over in
them:
if [ $? -ne 0 ]; then
echo "blah went wrong"
exit 1
fi
Anywhere such code doesn't happen is a bug.
> On another occasion, singular fails to install files with 'install-sh'
> as it could not find install-sh. This is despite there being about 15
> copies of install-sh in the singular distribution!!!
>
> I think it is only luck that it worked on linux, as the path given in
> singular is broken.
>
> It would be a good idea when creating new .spkg files that one actually
> checks that at least a subset of the files that are supposed to be
> installed in $SAGE_HOME/local, actually are installed - preferably all
> of them if possible.
>
> Comments?
That won't necessarily "prove" anything, since e.g., on doing an
upgrade the files might appear to be installed, but in fact old
versions are installed.
William
>
> Dave
>
> >
>
--
William Stein
Associate Professor of Mathematics
University of Washington
http://wstein.org
--~--~---------~--~----~------------~-------~--~----~
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~----------~----~----~----~------~----~------~--~---
