Hey John, I worked on it tonight, and I'm not sure how much you want to optimize it. Is a factor of 2 or 3 speedup worth making the code much less readable (I'd include comments, but...)? I could also probably improve a few things and get maybe 10% and leave it mostly as is. David
On Thu, Dec 17, 2009 at 5:20 PM, John Cremona <john.crem...@gmail.com>wrote: > 2009/12/17 David Roe <r...@math.harvard.edu>: > > I'd be happy to help you optimize it, but likely won't get around to it > > until this evening. If someone else wants to do so before then, go for > it. > > Thanks very much! > > John > > > > David > > > > On Thu, Dec 17, 2009 at 6:54 AM, John Cremona <john.crem...@gmail.com> > > wrote: > >> > >> I would welcome some comments or help on the patch at #7719. I have > >> not marked it as ready for review since I think that a cython expert > >> might be able to speed up the code (though it is already a lot faster > >> than what it replaces). For more explanation, see the ticket. > >> Thanks, > >> > >> John > >> > >> -- > >> To post to this group, send an email to sage-devel@googlegroups.com > >> To unsubscribe from this group, send an email to > >> sage-devel+unsubscr...@googlegroups.com<sage-devel%2bunsubscr...@googlegroups.com> > >> For more options, visit this group at > >> http://groups.google.com/group/sage-devel > >> URL: http://www.sagemath.org > > > > -- > > To post to this group, send an email to sage-devel@googlegroups.com > > To unsubscribe from this group, send an email to > > sage-devel+unsubscr...@googlegroups.com<sage-devel%2bunsubscr...@googlegroups.com> > > For more options, visit this group at > > http://groups.google.com/group/sage-devel > > URL: http://www.sagemath.org > > > > -- > To post to this group, send an email to sage-devel@googlegroups.com > To unsubscribe from this group, send an email to > sage-devel+unsubscr...@googlegroups.com<sage-devel%2bunsubscr...@googlegroups.com> > For more options, visit this group at > http://groups.google.com/group/sage-devel > URL: http://www.sagemath.org > -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
