>
> * document the helper functions get_sections(), print_contributors(),
> and print_section()
This is great - wonderful work! The below is just nitpicking, though
hopefully helpful.
I would recommend that we still obtain Authors and Reviewers (that is,
contributors) for "other tickets closed", which are often nontrivial
spkg updates or contributions to sagenb or sage that didn't happen to
get the merged field updated. That is to say,
for number, title, author, reviewer, merged in TICKET_RE.findall
(report):
if merged == section:
if section:
tickets[int(number)] = "".join([
author, ": ",
title,
" [Reviewed by %s]" % reviewer])
else:
tickets[int(number)] = title
The else: should also add author and reviewer, if possible. Even
better would be if things in sagenb were consistent - that is, if all
sagenb tickets were put as merged in sagenb-0.4.8 or whatever, and one
could have the script automatically do what Minh did in the last
release note, which is to have [Reviewed by X; merged in
sagenb-0.4.8].
There could also be a helper function which automatically detected the
length of the list of contributors, ran the doctest coverage script
and extracted things, etc., but probably that is better done by hand -
for instance, because sometimes there are multiple versions of the
same name on Trac.
Also (and this is probably more philosophical), it seems to me that a
file with .txt should not include non-ASCII characters. I know that
many contributors have accents and other diacritical marks on letters
in their names, but we don't use Unicode to put in Chinese characters
for contributors, either. I do not think all editors translate these
characters correctly, sometimes to the point of simply putting spaces
in, and unless we are assuming everyone has this correct, it actually
is worse than not having the accent or whatever on the name. Maybe
this is anti-internationalization, making something readable no matter
how non-international your setup is (for instance, if it is old but
still works).
- kcrisman
--
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org
