Hi Rob and Pat,
Thanks for your feedback!
I posted your two comments on trac for the reviewer.
On Wed, Feb 10, 2010 at 10:01:39PM -0800, Rob Beezer wrote:
> On Feb 9, 3:53 pm, "Nicolas M. Thiery" <nicolas.thi...@u-psud.fr>
> wrote:
> > * Implement the various options for both latex constructions (tikz or
> > dot2tex)
>
> I looked through the changes to latex (tikzpicture) code for graphs,
> to allow consistent handling of the dot2tex/graphviz output. It all
> looks fine and the tikzpicture environments seem to be unchanged, so I
> think backward compatibility is preserved here. And the changes, in
> addition to the bounding box code, will be useful when I come back to
> this.
Cool.
> My only comment regards line 313 of graph_latex.py, where the
> docstring suggests adding the tkz-graph package by joining a string to
> sage.misc.latex.LATEX_HEADER. This would be better accomplished by
> using the latex.add_to_preamble() call, which in particular won't add
> a string that is already there.
Thanks for the suggestion. Done.
> Thanks for your improvements and work on this!
Just scratching hard a big itch of mine :-)
Cheers,
Nicolas
--
Nicolas M. Thiéry "Isil" <nthi...@users.sf.net>
http://Nicolas.Thiery.name/
--
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org
