William Stein wrote:
On Wed, Apr 21, 2010 at 9:10 AM, David Kirkby <[email protected]
<mailto:[email protected]>> wrote:
On 21 April 2010 16:49, John H Palmieri <[email protected]
<mailto:[email protected]>> wrote:
> According to our documentation, the "src" directory in an spkg should
> contain the "vanilla upstream code". I've seen a few spkg's that
> modify this by deleting stuff:
>
> - they might delete documentation (as long as it's not used in any
> way by Sage)
> - they might delete a Mercurial repository (as long as it's just the
> upstream repo, not the one that's supposed to be there)
>
> These changes make the spkg files much smaller, which is good. But
> are these acceptable changes?
>
> --
> John
It has been customary to put a note in SPKG.txt under "Special
Instructions" things like
* Delete documentation in src/foobar as not needed
* Delete binary compaineis in src/bin
* Delete huge files in src/huge has not needed
So people know stuff has been removed.
Like you, I have seen things added too.
Why did you say "like you". Neither John nor I said that we have seen
things added. If something gets added to src/ that's horrible, and I
want to know about it. If you can remember anything, please let me
know, since that's really useful to remove.
Symmetrica is one example, where SPKG.txt says:
"== Special Update/Build Instructions ==
Against common policy the patches in the patches directory have been applied to
the src directory:"
http://trac.sagemath.org/sage_trac/ticket/8122
This has several files changed I believe.
I can't think of the package now, but there was at least one other where the
makefile has been hacked in the src directory.
dave
--
To post to this group, send an email to [email protected]
To unsubscribe from this group, send an email to
[email protected]
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org
