Hi David, On Wed, Sep 15, 2010 at 12:01 AM, Dr. David Kirkby <david.kir...@onetel.net> wrote: > I had my suspicions it was you, but I was not sure - I had no intentions of > accusing anyone unless I was sure. I had in fact cc'ed you on the ticket, > but you made no comments whatsoever.
I also touched the Cliquer spkg, so I feel partly responsible. > Another change that has been made is to the Makefile to build a shared > library. Again, not commented. > > There's nothing in SPKG.txt to indicate you added a shared library. I remember working on build issues for the Cliquer spkg. > But NONE of that should be to the upstream source code. How the hell I am > supposed to know what changes you have made? > > Sure, some have changes with "sage" in the name, but how does one really > know what else is changed? Am I expected to track down an old version of the > code (no longer on line), and try to work out what changes have been made? That is a valid comment. The idea of having the directory src/ within an spkg is for depositing pristine upstream code. > IMHO, if you can't be bothered to read the Sage developers guide and read > how .spkg files are supposed to be maintained, then you should not maintain > them. You do a very poor job of doing so, which creates headaches for > others. When Nathann and I worked on the Cliquer spkg during the 4th quarter of 2009, some sections of the Developer's Guide was not available then. One notable example is the section "Patching a Sage Package" [1]. Now there is little excuse for us or anyone maintaining/developing Sage and standard spkg's not to read the Developer's Guide. [1] http://www.sagemath.org/doc/developer/patching_spkgs.html -- Regards Minh Van Nguyen -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
