On 09/21/10 05:48 AM, John H Palmieri wrote:
On Sep 20, 5:39 pm, kcrisman<[email protected]> wrote:
"SAGE_CHECK - if this is set to “yes”, then during the build process,
run the test suite for each package which has one."
I think this should actually say
if this is set to any nonempty string, then ...
The relevant code is in the sage-spkg script:
if [ "$SAGE_CHECK" != "" -a -f spkg-check ]; then
echo "Running the test suite."
chmod +x spkg-check
./spkg-check
That's a particularly bad bit of code.
1) The Installation guide says it should be set to yes
http://www.sagemath.org/doc/installation/source.html#environment-variables
2) README.txt says it should be set to "yes"
3) William created a ticket for it to be documented to be "yes"
http://trac.sagemath.org/sage_trac/ticket/6282
4) Using "yes" is used for other variable, like "SAGE64" which is in every
single Sage package.
5) Lastly one should not test on an empty string like that - it is a bad
practice to get into.
So IMHO, setting it to "no", "fobar" or anything else except "yes" should not
run the tests.
Dave
--
To post to this group, send an email to [email protected]
To unsubscribe from this group, send an email to
[email protected]
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org
