On Thu, Oct 28, 2010 at 12:32 PM, Ondrej Certik <ond...@certik.cz> wrote: > On Thu, Oct 28, 2010 at 1:36 AM, leif <not.rea...@online.de> wrote: >> >> >> On 27 Okt., 09:56, Jeroen Demeyer <jdeme...@cage.ugent.be> wrote: >>> On 2010-10-27 09:36, Robert Bradshaw wrote:> The larger problem with the >>> current system is not that it's hard to >>> > comment on a single line, but it's way to much work to *fix* a single >>> > line. >>> >>> I would say it's mainly way too much work to get a single line *reviewed*. >> >> Well, that depends on the impact of such a change. >> >> Small ones can have large effects as you certainly know... > > Yes, but manytimes it's just some simple thing. > > Speaking for myself, given that I constantly loose my sage trac > account, I usually don't even try to send a simple patch fixing just > one line, only when there is some bigger chunk. This applies for all > projects... Except that recently, I started to send simple patches to > lots of projects that are hosted at github, because it's super simple > to send a one line change, super simple to review it and push it in. > See my other email in this thread about it. You can see my activity > here: > > http://github.com/certik > > So my own conclusion is that all things can still be properly > reviewed, and yet make it very easy for everyone, even for one line > changes.
This is exactly what I was talking about. Getting code into Sage should only be epsilon harder than writing the (quality) code (and doctests). Right now it's often several times as hard. - Robert -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
