On Tue, Mar 22, 2011 at 1:52 PM, Ethan Van Andel <[email protected]> wrote:
> What would people think about changing complex_plot.pyx in the
> following manner:
>
> ComplexPlot is changed so that the complex_to_rgb function is passed
> as a parameter on creation. The complex_plot function will then pass
> the currently defined complex_to_rgb to ComplexPlot when it is used.
> This allows different functions (currently complex_plot and
> Riemann_Map.plot_colored) to use their own coloring settings, or for
> hands on users to define and use their own coloring functions without
> having to modify the source? This also allows me to eliminate the
> redundancy in Riemann_Map. If this sounds like a good idea, I'll
> double check to make sure there are no significant performance
> ramifications.

I think such a modification would make sense. As complex_to_rgb
operates on the full array of values, there should be little to no
overhead for passing it around. (Actually, custom ones could probably
be written relatively efficiently in a vectorized format.)

- Robert

-- 
To post to this group, send an email to [email protected]
To unsubscribe from this group, send an email to 
[email protected]
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org

Reply via email to