On Jun 23, 12:14 pm, Rolf <[email protected]> wrote: > To be honest, I the Sage review process seems cumbersome to me. > > Following the instructions (http://www.sagemath.org/doc/developer/ > walk_through.html) I cloned a sub directory to hold my newly > implemented gsl probability distributions (binomial and negative > binomial to name only two). These work fine with my system. > > Next, I wanted to contribute these new distributions. As there already > exists a patch for the F distribution (http://trac.sagemath.org/ > sage_trac/attachment/ticket/9080/trac_9080-rebased.patch), I wanted to > review this first, but following the instructions for 'Reviewing a > patch' [hg_sage.apply("<full-path-and-filename.patch>") etc.] did not > change anything perceptible.
Probably you missed out the command to rebuild Sage library (i.e. exit Sage and then run sage -b) By the way, IMHO a better way for applying a patch is outside of Sage, using hg's queues: http://wiki.sagemath.org/MercurialQueues http://www.sagemath.org/doc/developer/walk_through.html#being-more-efficient-mercurial-queues > The F distribution still is not > available, and hg_sage.log() produces such a long list that even after > several minutes I became tired of scrolling down. When I check the > files that should be affected by the patch, nothing has changed. -- To post to this group, send an email to [email protected] To unsubscribe from this group, send an email to [email protected] For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
