On Mon, Oct 31, 2011 at 4:42 AM, Jeroen Demeyer <[email protected]> wrote: > Hello all, > > Simon King has a big patch at #11900 to speed-up categories. There were > some regressions at #9138, this patch fixes all of these and moreover, > even speeds up some things. This patch is quite important, there are > various tickets depending on it. > > I have already checked that the patch works and that it fixes all > obvious regressions from #9138. Somebody with some understanding of > categories really needs to look at the code and review it.
I have some understanding of categories in Sage. However, I gave up in frustration trying to apply 11900 and the required prerequisites, because I got tired of stuff like: Hunk #1 FAILED at 1 1 out of 1 hunks FAILED -- saving rejects to file sage/monoids/monoid.py.rej patching file sage/rings/finite_rings/integer_mod_ring.py Hunk #1 FAILED at 44 Hunk #2 FAILED at 78 Hunk #3 FAILED at 112 Hunk #4 FAILED at 122 ... Hunk #25 FAILED at ... Etc. I don't even know where to begin to get a copy of Sage with the patches from 11900 going. So, as a kindness to the reviewer (who may be me), can somebody build (or extract) a copy of Sage-4.7.3.alpha1 (say) on sage.math, apply all relevant patches for 11900, run "make ptestlong" and confirm that all tests pass, and make a bdist of the result? Then respond to this thread with a link to the bdist. To do the *interesting* part of referring this ticket I just need: (1) that bdist (2) to look at the patches linked to from 11900. When I'm reviewing, I need to be able to try out stuff with all the patches applied, to see what funny things I find. -- William > > Please see http://trac.sagemath.org/sage_trac/ticket/11900 > > > Jeroen. > > -- > To post to this group, send an email to [email protected] > To unsubscribe from this group, send an email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/sage-devel > URL: http://www.sagemath.org > -- William Stein Professor of Mathematics University of Washington http://wstein.org -- To post to this group, send an email to [email protected] To unsubscribe from this group, send an email to [email protected] For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
