On Dec 16, 2011 1:10 PM, "kcrisman" <[email protected]> wrote: > > > > On Dec 16, 3:00 pm, Jeroen Demeyer <[email protected]> wrote: > > On 2011-12-16 18:20, Michael Orlitzky wrote: > > > > > So that I'm no more annoying than necessary: what is the purpose of the > > > Author(s) field on a ticket? I've seen all three used: > > > > > 1 Whoever wrote the affected code > > > 2 The patch submitter > > > 3 The ticket submitter (this one can be ruled out) > > > > I vote for: > > > > 4. The person who wrote the patch (which can be different from the > > submitter). > > In practice, we are pretty generous about handing out credit for > this. I've seen a lot of tickets with: > > 1) A significant start provided by one person, perhaps in a comment or > in a proto-patch > 2) A "real" patch made by a second person > 3) A significant (though not huge) change made by a reviewer which has > to be reviewed > > and all three get authorial credit. > > And honestly, there's no reason not to do this, if it motivates people > to contribute :)
Moreover any of the above three can be a substantial amount of work, even if only a few lines change. Simon King has been refereeing a patch for mine recently, and probably wrote more code than me just to properly test my patch! > I think that most reviewers know when their > contribution in a reviewer patch is minimal enough to stay only on the > reviewer field, and I hope that most of us are giving credit to people > who do a significant amount of work that is documented on Trac but > doesn't happen to be in "official" patch form. > > - kcrisman > > -- > To post to this group, send an email to [email protected] > To unsubscribe from this group, send an email to [email protected] > For more options, visit this group at http://groups.google.com/group/sage-devel > URL: http://www.sagemath.org -- To post to this group, send an email to [email protected] To unsubscribe from this group, send an email to [email protected] For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
