Hi! #12290 is now ready for review.
For reference, the ticket contains one not-totally-finished patch that only improves the hash. However, the patch that is supposed to be reviewed goes beyond and introduces UniqueRepresentation as a base class of matrix spaces. First feature: All tests pass, the hash problem is fixed and in addition the hash is even faster than with the old patch. Second feature: Coercion of matrices is a lot nicer now, IMHO!! Namely, in unpatched sage, the parent of the sum of a dense and a sparse matrix implicitly depends on the summation order: sage: M = MatrixSpace(ZZ, 10) sage: N = MatrixSpace(ZZ, 10,sparse=True) sage: a = M.random_element() sage: b = N.random_element() sage: (a+b).parent() Full MatrixSpace of 10 by 10 dense matrices over Integer Ring sage: (b+a).parent() Full MatrixSpace of 10 by 10 sparse matrices over Integer Ring With my patch, the parent of b+a is the same as the parent of a+b. Cheers, Simon -- To post to this group, send an email to [email protected] To unsubscribe from this group, send an email to [email protected] For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
