On Tue, Feb 21, 2012 at 12:32 PM, Robert Bradshaw <[email protected]> wrote: > >> No, you can keep pushing to the branch you created the PR from, and >> new commits show up as they are made. You can even rebase and force >> push, and the PR will get rebased too. We do the first all the time, >> and the second also, though less frequently. > > What happens to (inline) comments in this case?
I think they get preserved as static snippets in the discussion page, but I'm not 100% sure. I know we have PRs that have gone through this, but I wouldn't know how to find one right now to verify; if you're really curious we could do a quick experiment with a fake PR to test what happens, it would not take long. Cheers, f -- To post to this group, send an email to [email protected] To unsubscribe from this group, send an email to [email protected] For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
